Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Experimental features and bug fixes #960

Merged
merged 144 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
144 commits
Select commit Hold shift + click to select a range
848ad00
feat: internal-fetch more powerful
nksaraf Oct 20, 2022
b816b42
fix (scss): fix scss/sass support for dev inline styles
nksaraf Oct 20, 2022
18a5e11
add example movies
nksaraf Oct 20, 2022
46cdedd
example(movies): add more routes for /movie and /tv
nksaraf Oct 20, 2022
15fe0fd
example(movies): add more pages
nksaraf Oct 20, 2022
114a8be
movies demo
nksaraf Oct 20, 2022
0fad643
fix(islands): css, prefetching, default A island
nksaraf Oct 20, 2022
08acf2a
enable islands for app
nksaraf Oct 20, 2022
85d82c6
clean up logging
nksaraf Oct 21, 2022
f823dd8
fix movies
nksaraf Oct 21, 2022
05acd80
bug fix: nested routing in islands server router
nksaraf Oct 21, 2022
e2a0d9d
css assets for islands router
nksaraf Oct 21, 2022
980e132
feat: persisted islands!!
nksaraf Oct 21, 2022
7bb0055
experiment: updated movies app to use folder-based routing
nksaraf Oct 21, 2022
ba6b36a
app layout as layout.tsx
nksaraf Oct 21, 2022
b8bebbc
remove logging
nksaraf Oct 21, 2022
26c7e89
layout support
nksaraf Oct 21, 2022
3077966
movies example: use folder based routing
nksaraf Oct 21, 2022
95489f8
Added PersonInfo and ExternalLinks components
Charca Oct 21, 2022
cb3dbaa
Removed v tags from vue and added conditional renderings of elements
Tanner-Scadden Oct 21, 2022
8f464da
Added in conditional to not render ListingCarousel if items does not …
Tanner-Scadden Oct 21, 2022
8f43fc0
Added debounce to the search for movies
Tanner-Scadden Oct 21, 2022
f2b0c49
Merge pull request #348 from Tanner-Scadden/movies
nksaraf Oct 21, 2022
590df62
Merge pull request #349 from Tanner-Scadden/movies-items-required
nksaraf Oct 21, 2022
8c1d35a
Merge pull request #350 from Tanner-Scadden/movies-search-debounce
nksaraf Oct 21, 2022
3fcfeea
Merge pull request #347 from Charca/movies
nksaraf Oct 21, 2022
5c225c1
Added more details and formatting to MovieInfo and Hero
Charca Oct 21, 2022
832d897
Removed stray console.log
Charca Oct 21, 2022
f91d140
cleanup
nksaraf Oct 21, 2022
ba205c1
move PersonInfo inside route and use unplugin icons
nksaraf Oct 22, 2022
fdc2218
Merge branch 'movies' of https://github.com/Charca/solid-start into C…
nksaraf Oct 22, 2022
07e0a94
example(movies): fix external links and image sizes
nksaraf Oct 22, 2022
66da063
movies: fix styles scss import
nksaraf Oct 22, 2022
895ba3d
fix some implementation details for islands
nksaraf Oct 23, 2022
14926f1
workers adapter seed function
nksaraf Oct 23, 2022
f055f0c
notes with server-components demo
nksaraf Oct 23, 2022
61a936d
example(notes): remove delay
nksaraf Oct 23, 2022
7d8f077
only preload used islands
nksaraf Oct 24, 2022
ec12425
examples(note): move components to directory
nksaraf Oct 24, 2022
56dc7f8
Merge branch 'internal-fetch' into notes
nksaraf Oct 24, 2022
e031698
fix: navigate not changing url state
zakybilfagih Oct 25, 2022
22268e0
example(movies): fix search param feature
zakybilfagih Oct 25, 2022
ce8a064
a fix
nksaraf Oct 26, 2022
6ff1790
notes example update
nksaraf Oct 26, 2022
71b9e5b
experimental islands mutation
nksaraf Oct 26, 2022
2b3d7f6
multiple JSX slots
nksaraf Oct 26, 2022
cfd977e
islands -> server components
nksaraf Oct 26, 2022
6e3fc8e
islands -> example
nksaraf Oct 26, 2022
4213a1a
fix
nksaraf Oct 26, 2022
d531734
Created Poster component to add 3d effect to Posters
paoloricciuti Oct 26, 2022
5e10825
Fix splitProps
paoloricciuti Oct 26, 2022
7f67de4
Update islands path from env manifest. Update vite plugin transform a…
dev-rb Oct 26, 2022
068a993
Add solid logo to nav bar.
dev-rb Oct 26, 2022
032b7fe
Merge pull request #369 from dev-rb/movies
nksaraf Oct 27, 2022
c65a583
fix islands build with use client
nksaraf Oct 27, 2022
fbefb09
add dark mode toggle
nksaraf Oct 27, 2022
d2014c2
notes example cleanup
nksaraf Oct 27, 2022
024782a
Merge pull request #363 from mackarelfish/movies
nksaraf Oct 27, 2022
9b14d9b
Merge pull request #368 from paoloricciuti/poster-effect
nksaraf Oct 27, 2022
f637ee9
Merge branch 'notes' into movies
nksaraf Oct 27, 2022
0d01606
cleanup client components
nksaraf Oct 27, 2022
cfcb541
Added Netlify adapter
davedbase Oct 27, 2022
2c2fcf1
Remove workspace reference
davedbase Oct 27, 2022
676ecd3
export things from root properly
nksaraf Oct 28, 2022
9ebb6c6
fix server-routing, use partial rendering on the server
nksaraf Oct 28, 2022
ab0c256
fix movie example
nksaraf Oct 28, 2022
023964e
Small css improvements
paoloricciuti Oct 28, 2022
637e569
Update paths for island transforms in vite plugin in dev mode.
dev-rb Oct 28, 2022
e65cc2a
Update paths for island references in islandsManifest generation in b…
dev-rb Oct 28, 2022
8f2e0ab
Add images to movies details page.
dev-rb Oct 28, 2022
a95ae80
fix stuff
nksaraf Oct 28, 2022
678727e
fix auto detect adapter for now
nksaraf Oct 28, 2022
f95cfe1
clean up logs
nksaraf Oct 28, 2022
4efeb00
clean up data fetching
nksaraf Oct 28, 2022
1db7fe5
fix route actions
nksaraf Oct 28, 2022
94fc6ee
Merge branch 'main' into notes
nksaraf Oct 28, 2022
beb8d5a
fix merge
nksaraf Oct 28, 2022
ea8688f
Merge branch 'notes' into movies
nksaraf Oct 28, 2022
bdca022
fix islands
nksaraf Oct 29, 2022
ca2ceb2
mounting fix
nksaraf Oct 29, 2022
a86dc36
Merge pull request #376 from paoloricciuti/small-css-fixes
nksaraf Oct 29, 2022
4d79c46
fix islands inside islands
nksaraf Oct 29, 2022
193d858
prisma example
nksaraf Oct 29, 2022
79b11f0
package json fixes
nksaraf Oct 29, 2022
b85ee64
Merge branch 'main' into movies
nksaraf Oct 29, 2022
1ce6282
Merge branch 'movies' of https://github.com/solidjs/solid-start into …
dev-rb Oct 30, 2022
9545ace
Update broken paths on Windows in dev mode. Add missing if statement …
dev-rb Oct 30, 2022
65d497a
Merge pull request #378 from dev-rb/movies
nksaraf Oct 30, 2022
a62aca9
fix typescript and new durable object API
nksaraf Oct 30, 2022
bfd93b8
fix notes durable object example
nksaraf Oct 30, 2022
8fa12d6
Merge branch 'movies' of https://github.com/solidjs/solid-start into …
nksaraf Oct 30, 2022
d9bc0c6
Merge remote-tracking branch 'origin/main' into movies
nksaraf Oct 30, 2022
cddd877
migrate notes to server components
nksaraf Oct 30, 2022
51b4393
in progress: fix types (cloudlfare durable objects are fucked up)
nksaraf Oct 31, 2022
4785dbf
Merge branch 'main' into dev
nksaraf Oct 31, 2022
ed9a9b9
typescript jump and bug fixes
nksaraf Oct 31, 2022
a295c26
ignore vite compiled configs
nksaraf Oct 31, 2022
cd4f899
ssr configurable with `render` entry
nksaraf Oct 31, 2022
fdbf8b1
Merge branch 'main' into dev
nksaraf Oct 31, 2022
6a4ae9f
islands type fixes
nksaraf Nov 4, 2022
6c671b3
notes
nksaraf Nov 4, 2022
72daad8
cleanup manifest code
nksaraf Nov 4, 2022
9b88248
Merge remote-tracking branch 'origin/main' into dev
nksaraf Nov 4, 2022
bac698b
fix islands router
nksaraf Nov 4, 2022
a7f53c3
fix islands stuff
nksaraf Nov 5, 2022
e087c0b
remove nprogress
nksaraf Nov 7, 2022
1be9eb8
fix adapters
nksaraf Nov 7, 2022
1c4a64b
better images for movies demo
ryansolid Nov 7, 2022
264b638
setup for streaming, fix accessibility
ryansolid Nov 7, 2022
297d245
add back loading indicator
ryansolid Nov 7, 2022
9c0181f
small tweak to loader
ryansolid Nov 7, 2022
8f7bc6b
movies updates
ryansolid Jul 12, 2023
4ce36cd
Merge branch 'main' of https://github.com/ryansolid/solid-start into dev
ryansolid Jul 13, 2023
a468741
fix dev and build
ryansolid Jul 14, 2023
abf8f56
fix DEBUG
ryansolid Jul 18, 2023
f4bd0d5
fix tests
ryansolid Jul 18, 2023
b428a53
fix SPA client build failing because of whitespace in path (#926)
edivados Jul 19, 2023
0e23a88
RouteAction returns undefined in case of error (#927)
frenzzy Jul 19, 2023
0450c31
docs/fix-trpc-example (#931)
jgibo Jul 20, 2023
71d3291
Update createRouteAction.md (#939)
Feel-ix-343 Jul 20, 2023
5985c9d
fix(data): update Form types in createRouteAction.tsx (#936)
caseybaggz Jul 20, 2023
c1b0a3c
0.2.27
ryansolid Jul 20, 2023
21d598a
remove layout support
ryansolid Jul 24, 2023
8f2f73f
remove more layouts
ryansolid Jul 25, 2023
105e851
Merge branch 'main' of https://github.com/ryansolid/solid-start into dev
ryansolid Jul 25, 2023
cd6ae51
fix lock
ryansolid Jul 25, 2023
84b0273
Merge branch 'main' of https://github.com/ryansolid/solid-start into dev
ryansolid Jul 27, 2023
53af09e
fix bad merge on server functions
ryansolid Jul 27, 2023
c6b42d1
fix notes demo
ryansolid Jul 31, 2023
8639d96
Merge branch 'main' of https://github.com/ryansolid/solid-start into dev
ryansolid Jul 31, 2023
c5e0f43
bump example versions
ryansolid Jul 31, 2023
d59bfa3
fix types
ryansolid Aug 1, 2023
a2fd2fa
possibly temp fix for tests until find better solution
ryansolid Aug 1, 2023
933ef2b
try deno specific internalFetch
ryansolid Aug 1, 2023
48c5e71
better deno fix
ryansolid Aug 1, 2023
0f677b0
fix missing reference
ryansolid Aug 1, 2023
25f7586
fix internalFetch
ryansolid Aug 2, 2023
159fd22
fixup cloudflare internalFetch
ryansolid Aug 2, 2023
cbad62e
add cloudflare internal fetch early exit
ryansolid Aug 2, 2023
3aab1bd
Merge branch 'main' of https://github.com/ryansolid/solid-start into dev
ryansolid Aug 4, 2023
09bec5c
update Solid to 1.7.9 (fix movies demo)
ryansolid Aug 4, 2023
2751645
normalize entries, fix docs
ryansolid Aug 7, 2023
96d1edb
fix docs build errors
ryansolid Aug 7, 2023
08d5f9c
Merge branch 'main' of https://github.com/ryansolid/solid-start into dev
ryansolid Aug 8, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@ netlify
# miniflare cache
.mf
.vercel

vite.config.ts.timestamp*
2 changes: 1 addition & 1 deletion components/TableOfContents.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function useTableOfContents() {
);
}

export default function TableOfContents() {
export function TableOfContents() {
const headings = useTableOfContents();

return (
Expand Down
3 changes: 1 addition & 2 deletions components/components.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { Title as MetaTitle } from "@solidjs/meta";
import { createUniqueId, mergeProps, Show } from "solid-js";
import { unstable_island } from "solid-start";
import "tippy.js/dist/tippy.css";
import A from "./A";
const Tooltip = unstable_island(() => import("./tooltip"));
import Tooltip from "./tooltip";

export const components = {
strong: props => <span class="font-bold">{props.children}</span>,
Expand Down
76 changes: 0 additions & 76 deletions components/docs.ts

This file was deleted.

30 changes: 12 additions & 18 deletions docs.root.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import { createMemo, For, Show, Suspense } from "solid-js";
import { MDXProvider } from "solid-mdx";
import {
A,
Body,
FileRoutes,
Head,
Expand All @@ -11,15 +12,11 @@ import {
Routes,
Scripts,
Stylesheet,
Title,
unstable_island
Title
} from "solid-start";
import { ErrorBoundary } from "solid-start/error-boundary";
import "./components/index.css";

const IslandA = unstable_island(() => import("./components/A"));
const TableOfContents = unstable_island(() => import("./components/TableOfContents"));

export const mods = /*#__PURE__*/ import.meta.glob<
true,
any,
Expand Down Expand Up @@ -132,6 +129,7 @@ function Nav() {
order: number;
subsection: string;
href: string;
frontMatter: any;
}[] & { subsection?: Set<string>; title?: string; order?: number };
} = {};

Expand Down Expand Up @@ -198,15 +196,15 @@ function Nav() {
<For each={r.filter(i => i.subsection === s)}>
{({ title, path, href, frontMatter }) => (
<li class="ml-2">
<IslandA
<A
activeClass="text-primary"
inactiveClass="text-gray-500"
href={href}
>
<span class="block ml-4 pb-2 text-sm break-words hover:text-gray-500 dark:hover:text-gray-300">
{title}
</span>
</IslandA>
</A>
</li>
)}
</For>
Expand All @@ -217,13 +215,9 @@ function Nav() {
<For each={r.filter(i => !i.subsection)}>
{({ title, path, href, frontMatter }) => (
<li class="ml-2">
<IslandA
activeClass="text-primary"
inactiveClass="text-gray-500"
href={href}
>
<A activeClass="text-primary" inactiveClass="text-gray-500" href={href}>
<span>{title}</span>
</IslandA>
</A>
</li>
)}
</For>
Expand All @@ -233,11 +227,11 @@ function Nav() {
<For each={r}>
{({ title, path, href, frontMatter }) => (
<li class="ml-2" classList={{ "text-slate-300": !frontMatter.active }}>
<IslandA activeClass="text-primary" inactiveClass="text-gray-500" href={href}>
<A activeClass="text-primary" inactiveClass="text-gray-500" href={href}>
<span class="block dark:text-gray-300 py-1 text-md font-semibold break-words hover:text-gray-400 dark:hover:text-gray-400">
{title}
</span>
</IslandA>
</A>
</li>
)}
</For>
Expand All @@ -250,7 +244,7 @@ function Nav() {
}

import { components } from "./components/components";
import { useTableOfContents } from "./components/TableOfContents";
import { TableOfContents, useTableOfContents } from "./components/TableOfContents";

export default function Root() {
return (
Expand Down Expand Up @@ -319,9 +313,9 @@ export default function Root() {
"ml-4": h.depth === 3
}}
>
<IslandA class="border-0 no-underline" href={`#${h.slug}`}>
<A class="border-0 no-underline" href={`#${h.slug}`}>
{h.text}
</IslandA>
</A>
</li>
)}
</For>
Expand Down
9 changes: 5 additions & 4 deletions docs/core-concepts/data-loading.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ export default function HouseLayout(props: ParentProps) {
return <><Outlet /></>;
}


// @filename: routes/[house]/students.tsx
import { RouteDataArgs, Outlet } from "solid-start";
import { ParentProps } from 'solid-js';
Expand Down Expand Up @@ -224,7 +225,7 @@ import { createContext } from 'solid-js';
const RouteContext = createContext<{ data: any }>({ data: null });

// ---cut---
import { useLocation, useNavigate } from "solid-start";
import { useLocation, useNavigate, RouteDataArgs } from "solid-start";
import {
default as HouseLayout,
routeData as getHouseLayoutData
Expand All @@ -245,9 +246,9 @@ function Routes() {
params: { house: 'gryffindor' }
}

const houseLayoutData = getHouseLayoutData({ ...args, data: null });
const studentsLayoutData = getStudentsLayoutData({ ...args, data: houseLayoutData });
const studentsData = getStudentsLayoutData({ ...args, data: studentsLayoutData });
const houseLayoutData = getHouseLayoutData({ ...args, data: null } as RouteDataArgs);
const studentsLayoutData = getStudentsLayoutData({ ...args, data: houseLayoutData } as RouteDataArgs);
const studentsData = getStudentsLayoutData({ ...args, data: studentsLayoutData } as RouteDataArgs);

return (
<RouteContext.Provider value={{ data: houseLayoutData }}>
Expand Down
12 changes: 6 additions & 6 deletions examples/bare/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,19 @@
},
"type": "module",
"devDependencies": {
"@types/node": "^18.11.18",
"@types/node": "^18.16.19",
"esbuild": "^0.14.54",
"postcss": "^8.4.21",
"solid-start-node": "^0.2.19",
"typescript": "^4.9.4",
"postcss": "^8.4.26",
"solid-start-node": "^0.2.29",
"typescript": "^4.9.5",
"vite": "^4.4.6"
},
"dependencies": {
"@solidjs/meta": "^0.28.2",
"@solidjs/meta": "^0.28.5",
"@solidjs/router": "^0.8.2",
"solid-js": "^1.7.9",
"solid-start": "^0.2.31",
"undici": "^5.15.1"
"undici": "^5.22.1"
},
"engines": {
"node": ">=16.8"
Expand Down
12 changes: 6 additions & 6 deletions examples/hackernews/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@
"type": "module",
"main": "./dist/index.js",
"devDependencies": {
"@types/babel__core": "^7.20.0",
"@types/node": "^18.11.18",
"@types/babel__core": "^7.20.1",
"@types/node": "^18.16.19",
"esbuild": "^0.14.54",
"solid-start-node": "^0.2.19",
"typescript": "^4.9.4",
"solid-start-node": "^0.2.29",
"typescript": "^4.9.5",
"vite": "^4.4.6"
},
"dependencies": {
"@solidjs/meta": "^0.28.2",
"@solidjs/meta": "^0.28.5",
"@solidjs/router": "^0.8.2",
"solid-js": "^1.7.9",
"solid-start": "^0.2.31",
"undici": "^5.15.1"
"undici": "^5.22.1"
},
"engines": {
"node": ">=16"
Expand Down
4 changes: 4 additions & 0 deletions examples/movies/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
node_modules
# Keep environment variables out of version control
.env*
.db
23 changes: 23 additions & 0 deletions examples/movies/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# solid-movies

This was adapted from the Nuxt version: https://github.com/tastejs/nuxt-movies

A SolidStart Movies application using [The Movie Database (TMDb)](https://developers.themoviedb.org/3) API. Built using [Solid](https://github.com/solidjs/solid) and [SolidStart](https://github.com/solidjs/solid-start). Our version is built by the Solid team.

## Quick setup

1. Take a copy of `.env.sample` and re-name to `.env`
2. Get your [TMDb](https://developers.themoviedb.org/3) API key
3. Get your [YouTube](https://developers.google.com/youtube/v3/getting-started) API key (optional, used for video data)
4. Enter the details into the `.env` file

## Running

``` bash
# install dependencies
$ npm install # Or yarn install

# serve with hot reload at localhost:3000
$ npm run dev
```

31 changes: 31 additions & 0 deletions examples/movies/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"name": "example-movies",
"scripts": {
"dev": "solid-start dev",
"build": "solid-start build",
"start": "solid-start start"
},
"type": "module",
"devDependencies": {
"@iconify/json": "^2.2.90",
"sass": "^1.63.6",
"solid-start-node": "^0.2.30",
"typescript": "^4.9.5",
"unplugin-icons": "^0.14.15",
"vite": "^4.4.6"
},
"dependencies": {
"@solid-primitives/scheduled": "1.1.0",
"@solidjs/meta": "^0.28.5",
"@solidjs/router": "^0.8.2",
"nprogress": "^0.2.0",
"solid-heroicons": "^3.2.4",
"solid-js": "^1.7.9",
"solid-start": "^0.2.30",
"solid-start-netlify": "^0.2.30",
"undici": "^5.22.1"
},
"engines": {
"node": ">=16"
}
}
12 changes: 12 additions & 0 deletions examples/movies/public/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# STATIC

This directory contains your static files.
Each file inside this directory is mapped to /.

Example: /static/robots.txt is mapped as /robots.txt.

More information about the usage of this directory in the documentation:
https://nuxtjs.org/guide/assets#static

**This directory is not required, you can delete it if you don't want to use it.**

Binary file added examples/movies/public/favicon.ico
Binary file not shown.
Binary file added examples/movies/public/icon-medium.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added examples/movies/public/icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions examples/movies/public/solidjs.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions examples/movies/src/assets/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# ASSETS

This directory contains your un-compiled assets such as LESS, SASS, or JavaScript.
Loading
Loading