Updates to Experimental features and bug fixes #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Movies Example] Removed v attributes and added in conditional renders
[Movies Example] Don't render ListingCarousel if it doesn't have any items
[Movies Example] Added debounce to the search
[Movies Example] PersonInfo and ExternalLinks components
Co-authored-by: Ryan Carniato <[email protected]>
yer I love open source
Co-authored-by: Ryan Carniato <[email protected]>
|
I fixed the types but tests are still broken in everything but node.. This commit is likely the culprit: 848ad00 It looks like it only updated node and not other environments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9 months ago @nksaraf and few others worked on a movies and notes demos to show off new Islands router capability and over the month made huge changes to Solid Start especially around experimental features I haven't been in the position to merge until now. This has delayed being able to merge improvements around these features against
mainsincedevhad moved so much.Key differences here is that all experimental flags being moved under experimental key on solid-start config, and that instead of the
unstable_islandsthis usesuse clientto define Islands. This is still still very experimental but in order to move forward we need to get this back into the trunk.Hopefully nothing else has broken due to these changes and I've tried my best to vet my merge the last couple weeks but you never know. I still need to get types updated and I've noticed some bugs around islands routing that I need to look into as well.