Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General cheatcode #2163

Closed
wants to merge 22 commits into from
Closed

General cheatcode #2163

wants to merge 22 commits into from

Conversation

piotmag769
Copy link
Contributor

@piotmag769 piotmag769 commented Jul 3, 2023 •
edited
Loading

Related cairo fork PR: software-mansion-labs/cairo#93

Checklist

  • Relevant issue is linked
  • Docs updated/issue for docs created
  • Added relevant tests

@piotmag769 piotmag769 linked an issue Jul 3, 2023 that may be closed by this pull request
Migrate cheatcodes to use single cheatcode libfunc #2072
Closed
@piotmag769 piotmag769 force-pushed the 2072-migrate-cheatcodes-to-use-single-cheatcode-libfunc branch from c193432 to e2b1988 Compare July 3, 2023 22:45
@piotmag769 piotmag769 marked this pull request as ready for review July 4, 2023 00:11
@piotmag769 piotmag769 requested a review from a team as a code owner July 4, 2023 00:11
@piotmag769 piotmag769 requested review from MaksymilianDemitraszek, karol-bisztyga, Arcticae and cptartur and removed request for a team July 4, 2023 00:11
@piotmag769 piotmag769 mentioned this pull request Jul 4, 2023
Closed
3 tasks
MaksymilianDemitraszek
MaksymilianDemitraszek reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@MaksymilianDemitraszek MaksymilianDemitraszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments regarding TODOs, we should convert them to issues. Otherwise great work 🔥 It will be very beneficial for the whole project.

protostar-rust/tests/data/dispatchers/src/hello_starknet.cairo Show resolved Hide resolved
protostar-rust/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
protostar-rust/src/running.rs Outdated Show resolved Hide resolved
karol-bisztyga
karol-bisztyga suggested changes Jul 4, 2023
View reviewed changes
protostar-rust/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
protostar-rust/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
protostar-rust/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
protostar-rust/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
protostar-rust/src/cheatcodes_hint_processor.rs Outdated Show resolved Hide resolved
protostar-rust/tests/data/declare_test/src/lib.cairo Show resolved Hide resolved
@piotmag769 piotmag769 mentioned this pull request Jul 4, 2023
Closed
3 tasks
@piotmag769 piotmag769 requested a review from cptartur July 4, 2023 13:42
@cptartur cptartur removed their request for review July 5, 2023 08:05
@cptartur cptartur assigned cptartur and unassigned piotmag769 Jul 5, 2023
Arcticae
Arcticae approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.circleci/config.yml Show resolved Hide resolved
protostar-rust/src/running.rs Show resolved Hide resolved
@cptartur cptartur mentioned this pull request Jul 5, 2023
Closed
karol-bisztyga
karol-bisztyga suggested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@karol-bisztyga karol-bisztyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address this: #2163 (comment)

@cptartur cptartur enabled auto-merge July 6, 2023 12:19
@cptartur cptartur disabled auto-merge July 6, 2023 12:20
@cptartur cptartur mentioned this pull request Jul 6, 2023
Closed
@Radinyn Radinyn closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@karol-bisztyga karol-bisztyga karol-bisztyga approved these changes

@Arcticae Arcticae Arcticae approved these changes

@MaksymilianDemitraszek MaksymilianDemitraszek Awaiting requested review from MaksymilianDemitraszek

Assignees

@cptartur cptartur

Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate cheatcodes to use single cheatcode libfunc
6 participants
@piotmag769 @MaksymilianDemitraszek @Arcticae @cptartur @karol-bisztyga @Radinyn