Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cheatcodes panic #2152

Closed
wants to merge 3 commits into from
Closed

Fix cheatcodes panic #2152

wants to merge 3 commits into from

Conversation

Radinyn
Copy link
Contributor

@Radinyn Radinyn commented Jun 29, 2023

Checklist

  • Relevant issue is linked
  • Docs updated/issue for docs created
  • Added relevant tests

@Radinyn Radinyn self-assigned this Jun 29, 2023
@Radinyn Radinyn linked an issue Jun 29, 2023 that may be closed by this pull request
Fix cheatcodes panic in rust runner #2148
Closed
@Radinyn Radinyn changed the base branch from master to 1992-contract-calling June 29, 2023 14:10
@piotmag769 piotmag769 mentioned this pull request Jun 29, 2023
Merged
3 tasks
@piotmag769 piotmag769 self-requested a review June 30, 2023 11:54
@cptartur
Copy link
Member

#2144 will introduce some more panicking code and will probably get merged before this PR. These should probably be addressed here.

Base automatically changed from 1992-contract-calling to master June 30, 2023 13:46
@piotmag769 piotmag769 mentioned this pull request Jul 4, 2023
Closed
3 tasks
@piotmag769
Copy link
Contributor

Please wait with merging for #2163 and rebase on top of it.
Make sure to address unwraps the aforementioned introduced, e.g. these:
#2163 (comment)

@github-actions github-actions bot added the size/S label Jul 5, 2023
@Radinyn Radinyn force-pushed the 2148-fix-cheatcodes-panic branch from 9fff67f to ae1a1c5 Compare July 5, 2023 07:38
@github-actions github-actions bot added size/M and removed size/S labels Jul 5, 2023
@Radinyn Radinyn marked this pull request as ready for review July 5, 2023 10:26
@Radinyn Radinyn requested a review from a team as a code owner July 5, 2023 10:26
@Radinyn Radinyn requested review from karol-bisztyga and removed request for a team July 5, 2023 10:26
karol-bisztyga
karol-bisztyga suggested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@karol-bisztyga karol-bisztyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls re-request review when #2163 is merged in u rebase to those changes.

@Radinyn Radinyn closed this Jul 7, 2023
@piotmag769 piotmag769 removed their request for review July 18, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karol-bisztyga karol-bisztyga karol-bisztyga requested changes

Assignees

@Radinyn Radinyn

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix cheatcodes panic in rust runner
4 participants
@Radinyn @cptartur @piotmag769 @karol-bisztyga