Added documentation for bulk entity extension #1543
Conversation
| public function collect(): \Generator | ||
| { | ||
| yield 'product' => [ |
There was a problem hiding this comment.
| yield 'product' => [ | |
| yield \Shopware\Core\Content\Product\ProductDefinition::ENTITY_NAME => [ |
should we encourage the usage of the constants? 🤔
There was a problem hiding this comment.
I see what you mean. I would document it in this way because Entities via Attributes or custom entities don't have such constants and the constant is also no "official" requirement right?
It also refer to the "definition" again, something which might be obsolete in the future
Therefore i would recommend to show it in this way i guess.
There was a problem hiding this comment.
@OliverSkroblin yes and the entities via attributes are a hell without these constants! I will provide a fix soon, that allows using the AttributeEntity::class as reference. This is such a mess as this will hold us back from using it the Doctrine ORM way.
It was really difficult to find out how to extend an attribute entity >:(
There was a problem hiding this comment.
Why is that such a hassle? You can simply reference the table name. You don’t always have to use constants everywhere ;).
If this is important for all of you, i would recommend to add a class constant again. I would always go the way of using a simple string which make it much more readable.
There was a problem hiding this comment.
Fun thing. I would always go for the PHP symbol so I can ensure the "magic string" is stored on a symbol, that is affected by refactorings correctly. This helps to understand by just looking at the uses what my real-life dependencies are. I see the benefit in the simplicity at time of writing, not at time of maintaining.
see shopware/shopware#5363