-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pending ordinal transactions to be shown #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Imamah-Zafar
changed the title
Remove check to not include ordinal address as recipient address
Allow pending ordinal transactions to be shown
Aug 11, 2023
…into imamahzafar/show-pending-ordinal-tx
|
m-aboelenein
approved these changes
Aug 16, 2023
teebszet
added a commit
that referenced
this pull request
Aug 22, 2023
* bump version to 1.6.2 * Revert "Remove check to not include ordinal address as recipient address (#211)" This reverts commit 2356a36. --------- Co-authored-by: Tim Man <[email protected]>
1 task
teebszet
added a commit
that referenced
this pull request
Aug 25, 2023
teebszet
pushed a commit
that referenced
this pull request
Nov 5, 2024
Co-authored-by: Den <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
Currently the ordinal pending transactions are not properly shown. Also the recipient address is always set as btc address for ordinals.
Issue Link: #[ENG-2618]
Context Link (if applicable):
🔄 Changes
Does this PR introduce a breaking change?
Changes:
Impact:
Test ordinal transfer with extension PR
🖼 Screenshot / 📹 Video
✅ Review checklist
Please ensure the following are true before merging: