Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pending ordinal transactions to be shown #211

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

Imamah-Zafar
Copy link
Contributor

@Imamah-Zafar Imamah-Zafar commented Aug 11, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

Currently the ordinal pending transactions are not properly shown. Also the recipient address is always set as btc address for ordinals.

Issue Link: #[ENG-2618]
Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • The check to not add ordinal address in the output address list has been removed in this PR

Impact:
Test ordinal transfer with extension PR

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@Imamah-Zafar Imamah-Zafar changed the title Remove check to not include ordinal address as recipient address Allow pending ordinal transactions to be shown Aug 11, 2023
@github-actions
Copy link
Contributor

Test this PR with npm i @secretkeylabs/[email protected]

@m-aboelenein m-aboelenein merged commit 2356a36 into develop Aug 16, 2023
3 checks passed
@m-aboelenein m-aboelenein deleted the imamahzafar/show-pending-ordinal-tx branch August 16, 2023 11:10
teebszet added a commit that referenced this pull request Aug 22, 2023
teebszet added a commit that referenced this pull request Aug 22, 2023
* bump version to 1.6.2

* Revert "Remove check to not include ordinal address as recipient address (#211)"

This reverts commit 2356a36.

---------

Co-authored-by: Tim Man <[email protected]>
@teebszet teebszet mentioned this pull request Aug 22, 2023
5 tasks
teebszet added a commit that referenced this pull request Aug 25, 2023
teebszet added a commit that referenced this pull request Oct 4, 2023
teebszet pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants