fix: stacks nft sorting by using the fully qualified token id (#211)

Co-authored-by: Den <[email protected]>
secretkeylabs · Oct 10, 2024 · 170bbad · 170bbad
1 parent d607d67
commit 170bbad
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/stacksCollectible/index.ts b/stacksCollectible/index.ts
@@ -155,8 +155,8 @@ export function applySortAndCollectionsFilters(
     const orderedCollection = {
       ...collection,
       all_nfts: collection.all_nfts.sort((a, b) => {
-        const aStarred = starredCollectibleIds.indexOf(`${a.asset_identifier}::${a.identifier.tokenId}`);
-        const bStarred = starredCollectibleIds.indexOf(`${b.asset_identifier}::${b.identifier.tokenId}`);
+        const aStarred = starredCollectibleIds.indexOf(`${a.asset_identifier}:${a.identifier.tokenId}`);
+        const bStarred = starredCollectibleIds.indexOf(`${b.asset_identifier}:${b.identifier.tokenId}`);
         // Non-starred items have -1, so they should move to the right
         if (aStarred === -1) return 1;
         if (bStarred === -1) return -1;

diff --git a/tests/stacks/stacksNfts.test.ts b/tests/stacks/stacksNfts.test.ts
@@ -398,7 +398,7 @@ describe('applySortAndCollectionsFilters', () => {
   });
 
   it('should show starred NFTs inside a collection in front', () => {
-    const starredCollectibleIds = ['SP497E7RX3233ATBS2AB9G4WTHB63X5PBSP5VGAQ.boom-nfts::boom::13285'];
+    const starredCollectibleIds = ['SP497E7RX3233ATBS2AB9G4WTHB63X5PBSP5VGAQ.boom-nfts::boom:13285'];
     const result = applySortAndCollectionsFilters(mockStacksCollection, { starredCollectibleIds });
     expect(result).toStrictEqual(mockStarredItemInACollection);
   });