Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordinal transaction functions #201

Conversation

abdulhaseeb4239
Copy link
Contributor

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

We needed to move all the ordinals transactions logic to xverse-core. Including fetching and address UTXOs and getting the correct UTXO to send.

Issue Link: https://linear.app/xverseapp/issue/ENG-2528/move-ordinal-transactions-logic-to-xverse-core
Context Link (if applicable):

🔄 Changes

I have created new functions to wrap up the existing ones. I passed the ordinal inscription and isRecover boolean. and function fetches the addressUtxos from ordinalAddress and from btcAddress if it's a recover transaction.

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • modified transactions/btc.ts file to add new functions for getting fees for ordinal send transactions and signing ordinal transactions.

Impact:

  • This will help keep the logic consistent across the app and extension. and future changes will be much easier.
  • Impact on downstream apps, link to issues or PRs for migration (TODO)
  • Ordinals Transfer and Ordinal Recover

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

transactions/btc.ts Outdated Show resolved Hide resolved
transactions/btc.ts Outdated Show resolved Hide resolved
transactions/btc.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Test this PR with npm i @secretkeylabs/[email protected]

Copy link
Member

@teebszet teebszet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teebszet
Copy link
Member

teebszet commented Aug 9, 2023

@abdulhaseeb4239 can we merge this, since it's a non-breaking change? can do more testing on the web-extension and mobile PRs

@abdulhaseeb4239
Copy link
Contributor Author

@abdulhaseeb4239 can we merge this, since it's a non-breaking change? can do more testing on the web-extension and mobile PRs

yes we can merge

@teebszet teebszet merged commit 9d12451 into develop Aug 9, 2023
3 checks passed
@teebszet teebszet deleted the abdulhaseeb/eng-2528-move-ordinal-transactions-logic-to-xverse-core branch August 9, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants