-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated ordinals tx functions #552
refactor: updated ordinals tx functions #552
Conversation
@abdulhaseeb4239 code looks good, but missing videos or details of local tests. |
has conflicts |
…-extension into abdulhaseeb/eng-2551-updated-functions-for-ordinal-transactions
…r-ordinal-transactions
…sactions' of https://github.com/secretkeylabs/xverse-web-extension into abdulhaseeb/eng-2551-updated-functions-for-ordinal-transactions
@abdulhaseeb4239 the recover flow wasn't working? pr has conflicts again |
…-extension into abdulhaseeb/eng-2551-updated-functions-for-ordinal-transactions
yes, it was not working properly. the ordinal UTXOs were not being fetched from API to filter UTXOs from fees. The change is in core |
I'll be testing this pr with the latest xverse-core https://github.com/secretkeylabs/xverse-core/releases/latest at the time of writing it was 1.6.5 |
left my findings in the linear ticket ENG-2551 |
…-extension into abdulhaseeb/eng-2551-updated-functions-for-ordinal-transactions
@DuskaT021 was this one ready to merge? I can't remember if it was on a discord thread |
it was in linear here - not ready for merge, needs to be retested, after the xverse-core updated |
@abdulhaseeb4239 needs conflicts resolved |
done |
left a comment in the linear ticket @abdulhaseeb4239 |
|
…ering Remove Alex SIP-10 tokens filtering
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
Moved ordinal transactions logic to xverse-core
Issue Link: https://linear.app/xverseapp/issue/ENG-2551/updated-functions-for-ordinal-transactions
Context Link (if applicable): https://linear.app/xverseapp/issue/ENG-2528/move-ordinal-transactions-logic-to-xverse-core
🔄 Changes
Updated ordinals transactions functions from xverse-core
This PR depends on xverse-core PR secretkeylabs/xverse-core#218
Impact:
Testing:
I have tested send Ordinal and recover Ordinal flow on iOS simulator.
Testing Instruction:
🖼 Screenshot / 📹 Video
Screen.Recording.2023-08-15.at.12.13.10.PM.mov
✅ Review checklist
Please ensure the following are true before merging: