Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asv benchmark code #784

Merged
merged 19 commits into from
Nov 27, 2024
Merged

Add asv benchmark code #784

merged 19 commits into from
Nov 27, 2024

Conversation

berombau
Copy link
Contributor

This would close #769 and allow developers to contribute a reproducible benchmark to check specific certain issues. E.g. work on spatial partitioning support #739

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (f758039) to head (ad31623).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          45       45           
  Lines        6959     6959           
=======================================
  Hits         6389     6389           
  Misses        570      570           

@berombau berombau changed the title [WIP] add asv benchmark code Add asv benchmark code Nov 27, 2024
benchmarks/README.md Outdated Show resolved Hide resolved
benchmarks/README.md Outdated Show resolved Hide resolved
benchmarks/utils.py Outdated Show resolved Hide resolved
@LucaMarconato
Copy link
Member

Thanks for the edits! I reviewed them and we are ready to merge!

@LucaMarconato LucaMarconato merged commit 8c12732 into scverse:main Nov 27, 2024
4 of 7 checks passed
@berombau berombau deleted the benchmark-asv branch November 27, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choosing a performance profiling framework
2 participants