Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lombok dependencies to data loader project #2030

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add lombok dependencies to data loader project #2030

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c76ece
Add lombok dependencies to data loader project
ypeckstadt Jul 4, 2024
1f3fe04
Merge branch 'master' into feat/dataloader/lombok
ypeckstadt Nov 27, 2024
d5636e5
Remove unnecessary lines
ypeckstadt Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion data-loader/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
subprojects {
group = "scalardb.dataloader"

ext {
apacheCommonsLangVersion = '3.14.0'
apacheCommonsIoVersion = '2.16.1'
lombokVersion = '1.18.34'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed ext block that defines dependency versions is written in the root build.gradle. How about moving this block into it? It has commonsLangVersion = '3.14.0' always.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I will use the commonsLangVersions. That said, I added the ext in this build.gradle file to separate some dependencies that only apply to the data-loader subprojects. I don't think Lombok will be used in other (sub)projects.

}
dependencies {
// AssertJ
Expand All @@ -23,5 +23,11 @@ subprojects {
testImplementation "org.mockito:mockito-core:${mockitoVersion}"
testImplementation "org.mockito:mockito-inline:${mockitoVersion}"
testImplementation "org.mockito:mockito-junit-jupiter:${mockitoVersion}"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. Unnecessary empty line?

// Lombok
compileOnly "org.projectlombok:lombok:${lombokVersion}"
annotationProcessor "org.projectlombok:lombok:${lombokVersion}"
testCompileOnly "org.projectlombok:lombok:${lombokVersion}"
testAnnotationProcessor "org.projectlombok:lombok:${lombokVersion}"
}
}