Add lombok dependencies to data loader project #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
komamitsu
reviewed
Jul 5, 2024
| ext { | ||
| apacheCommonsLangVersion = '3.14.0' | ||
| apacheCommonsIoVersion = '2.16.1' | ||
| lombokVersion = '1.18.34' |
There was a problem hiding this comment.
I noticed ext block that defines dependency versions is written in the root build.gradle. How about moving this block into it? It has commonsLangVersion = '3.14.0' always.
There was a problem hiding this comment.
Good point. I will use the commonsLangVersions. That said, I added the ext in this build.gradle file to separate some dependencies that only apply to the data-loader subprojects. I don't think Lombok will be used in other (sub)projects.
brfrn169
approved these changes
Jul 9, 2024
| @@ -1,9 +1,11 @@ | |||
| subprojects { | |||
| group = "scalardb.dataloader" | |||
|
|
|||
|
|
|||
| @@ -23,5 +25,12 @@ subprojects { | |||
| testImplementation "org.mockito:mockito-core:${mockitoVersion}" | |||
| testImplementation "org.mockito:mockito-inline:${mockitoVersion}" | |||
| testImplementation "org.mockito:mockito-junit-jupiter:${mockitoVersion}" | |||
|
|
|||
There was a problem hiding this comment.
Ditto. Unnecessary empty line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR adds the dependencies to the shared
build.gradlefile for all data loader sub-projects.Related issues and/or PRs
NA
Changes made
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas.[ ] I have updated the documentation to reflect the changes.[ ] Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).[ ] Tests (unit, integration, etc.) have been added for the changes.Additional notes (optional)
NA
Release notes
NA