Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backjumping by checking if broken_state.mapping is empty #152

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

notatallshaw
Copy link
Collaborator

@notatallshaw notatallshaw commented Jun 14, 2024

Fixes #134

Still need to provide a test, going to see if I can write a small provider that can process the JSON in #134 (comment) and follows pip's preference logic.

But feedback would be welcome.

@notatallshaw notatallshaw marked this pull request as draft June 14, 2024 00:17
@notatallshaw notatallshaw changed the title Fix backjumping back checking if name in incompatible_deps Fix backjumping by checking if name in incompatible_deps Jun 14, 2024
@notatallshaw notatallshaw force-pushed the fix-backjumping branch 4 times, most recently from 21070db to 4e14364 Compare June 14, 2024 23:31
@notatallshaw notatallshaw changed the title Fix backjumping by checking if name in incompatible_deps Fix backjumping by checking if broken_state.mapping is empty Jun 14, 2024
@notatallshaw
Copy link
Collaborator Author

notatallshaw commented Jun 14, 2024

Upon writing a test case I realized it wasn't sufficient to check if name is in incompatible dependencies, but the simpler check of checking if broken_state.mapping is empty is sufficient.

@notatallshaw
Copy link
Collaborator Author

notatallshaw commented Jun 14, 2024

Actually, while this solves the given test case, I found it still fails for "kedro[test]==0.18.13".

I am going to leave this PR as ready to review, because I still beleive it's correct to exit from backtracking when broken_state.mapping is empty.

But I am going to try and create another minimal example from "kedro[test]==0.18.13".

@notatallshaw
Copy link
Collaborator Author

notatallshaw commented Jun 15, 2024

I found it still fails for "kedro[test]==0.18.13"

After a bit of investigation I found that this is probably an edge case related to extras. I am investigating further, but it could be an issue on pip side. I plan to make a separate issue once I have found a simple reproducer. I would like this PR to be treated as solving the original example in #134

@uranusjr uranusjr merged commit ffa7199 into sarugaku:main Jun 20, 2024
9 checks passed
@notatallshaw notatallshaw mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An example of resolution failure while it does have a valid resolution.
2 participants