-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backjumping by checking if broken_state.mapping is empty #152
Conversation
21070db
to
4e14364
Compare
Upon writing a test case I realized it wasn't sufficient to check if name is in incompatible dependencies, but the simpler check of checking if broken_state.mapping is empty is sufficient. |
4e14364
to
5688e55
Compare
Actually, while this solves the given test case, I found it still fails for "kedro[test]==0.18.13". I am going to leave this PR as ready to review, because I still beleive it's correct to exit from backtracking when broken_state.mapping is empty. But I am going to try and create another minimal example from "kedro[test]==0.18.13". |
After a bit of investigation I found that this is probably an edge case related to extras. I am investigating further, but it could be an issue on pip side. I plan to make a separate issue once I have found a simple reproducer. I would like this PR to be treated as solving the original example in #134 |
Fixes #134
Still need to provide a test, going to see if I can write a small provider that can process the JSON in #134 (comment) and follows pip's preference logic.
But feedback would be welcome.