-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kedro[test]==0.18.13
fails even though requiring its depndencies do not
#12768
Comments
Probably realted to #12317, but other requirement examples are fixed by sarugaku/resolvelib#152 so I wanted to track this one, and it's peculiarities, seperately. |
Here is a relatively minimal reproducer example that's easier to prove is an issue: Create a pyproject.toml like so: [build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"
[project]
name = "reproducer"
authors = [
{name = "reproducer"}
]
version = "0.0.1"
description = "reproducer"
dependencies = [
"adlfs~=2023.1",
"dask[complete]~=2021.10",
"gcsfs>=2023.1, <2023.3",
] Run
Now run
|
kedro[test]==0.18.13
fails even though requiring it's depndencies does notkedro[test]==0.18.13
fails even though requiring its depndencies do not
@notatallshaw IIUC, this has been fixed in resolvelib and we need to pull in that fix here? |
No, this is an example of a requirement not fixed by the fallback implemented in resolvelib. Either, backjumping needs to be removed (or made optional) to fix this, or we go with sarugaku/resolvelib#134 (comment) and document the provider needs to behave in a certain way, and then we will need to update the pip provider to comply. I am working on a PR on the resolvelib side to document this behavior, and give an example with a test provider, and then we'll see where we go from there. |
This will be fixed once resolvelib releases and it is vendored: sarugaku/resolvelib#155 |
Updating to pip 25.0 milestone as I reason here: sarugaku/resolvelib#159 (comment) |
Description
On Linux Python 3.9 installing
kedro[test]==0.18.13
fails with resolution impossibleHowever if you directly specify it's requirements as extracted from the metadata (https://files.pythonhosted.org/packages/50/01/76d44fd50471cd1bd9899e161c07444026c954c01a9012b2c3a8f8a9e1c5/kedro-0.18.13-py3-none-any.whl.metadata) e.g.:
Then it installs fine. Also uv and older vesions of pip can install
kedro[test]==0.18.13
.Expected behavior
kedro[test]==0.18.13
installs finepip version
24.0
Python version
3.9
OS
Linux
How to Reproduce
Output
Code of Conduct
The text was updated successfully, but these errors were encountered: