-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New section describing familial PEDIGREE headers #413
Open
jmarshall
wants to merge
5
commits into
samtools:master
Choose a base branch
from
jmarshall:pedigree
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0e7b06a
[DRAFT] Outline of new familial ##PEDIGREE section
jmarshall 2fcd817
Restructured where is PEDIGREE meta explained
a35d422
Add example of PED to VCF conversion
jmmut 36b3918
VCF: add references in pedigree example
jmmut f1bc982
VCF: add siblings to pedigree section
jmmut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the line I'm interested in but I can't comment on the other one. PED does not support more than 2 ancestors, do we want to do it in VCF? I have never seen this used so I don't think a lot of people will miss it if we drop it. That will make trivial to add some examples for trios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pd3 @lbergelson what should we do about this? Dropping support for more than 2 ancestors would render some files incorrect, but as I said in my previous comment I have never seen that syntax being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there would be a lot of pushback against dropping multiple ancestor lines because they seem pretty ambiguously defined at the moment and I haven't ever seen one used... That said, we should maybe not be making breaking changes to an existing spec?
Are they intended only for asexual ancestry where each is the parent of the next? Or are they just an unsorted bag of ancestors that could represent any tree of parentage?
i.e does
<ID=SampleID,Name_1=Ancestor_1,...,Name_N=Ancestor_N>
imply
or could it also mean
I lean towards removing or deprecating it if we don't know exactly what it means and no one seems to be using it.
I'm also not clear on which of these are controlled vocabulary. Is there a specific ontology of relationships that are allowed? Are we allowed to specify something like
Sibling
in the case where we don't have parent in the vcf or is that handled with dummy trios that point to unique but not present parents ID'sAre you allowed to include only 1 parent or are trios required?
I assume the example would address some of these questions.