Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial VCF formatting improvements #411

Merged
merged 1 commit into from
May 29, 2019

Conversation

jmarshall
Copy link
Member

Avoid end-of-sentence spacing after i.e. / e.g. / cf. Where i.e. or e.g. delimits separate clauses, use a comma to set it off, e.g., as the previous comma does in this sentence.

Previously (PR #391) I did this only in VCFv4.3 (and neglected cf.). This extends this minor improvement to the other two documents.

No changes to the format or descriptions, so this should be straightforward to review and merge.

Where i.e. or e.g. delimits separate clauses, use a comma to
set it off, e.g., as the previous comma does in this sentence.
@hts-specs-bot
Copy link

Changed PDFs as of 103fd99: VCFv4.1 (diff), VCFv4.2 (diff), VCFv4.3 (diff).

@jmarshall
Copy link
Member Author

@cyenyxe @lbergelson @pd3 — It would be great if one of you would glance at and merge this trivial formatting change. I have other PRs that I would like to rebase on top of this…

@pd3 pd3 self-requested a review May 24, 2019 09:28
Copy link
Member

@pd3 pd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, this is good. Thank you

@jmarshall jmarshall merged commit 103fd99 into samtools:master May 29, 2019
@jmarshall jmarshall temporarily deployed to github-pages May 29, 2019 09:18 Inactive
@jmarshall jmarshall deleted the vcf-ie-eg-cf branch May 29, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants