Rearrange person profile #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lislis
force-pushed
the
lp-rearrange-person-profile
branch
from
6d7ae34
to
41d2b30
Compare
|
I didn't realise that we are using both scss and sass syntax in our styles... Do you think we should transition them all to one syntax? You don't have to do it in this PR, but thought I would ask. |
|
you're right, we probably should 😅 |
|
We can do that soon. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this solving an issue already in our backlog? If so, please mention which one
#597
Here is a pic with the new arrangement of all things that can be in the profile
