refactor some view code into partial

rubycorns · May 15, 2018 · 41d2b30 · 41d2b30
1 parent e8e2ee7
commit 41d2b30
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 37 deletions.
diff --git a/app/views/groups/_meeting_info.haml b/app/views/groups/_meeting_info.haml
@@ -0,0 +1,17 @@
+%p
+  %strong 🗓️ When
+  - if group.time?
+    = group.time
+  - else
+    %span.info-not-given
+      not specified
+%p
+  %strong 🏢 Meeting place
+  - if group.address?
+    = group.address
+  - else
+    %span.info-not-given
+      not specified
+%p
+  %strong 🗺️ Address
+  = group_location(group)
diff --git a/app/views/groups/_one_group.html.haml b/app/views/groups/_one_group.html.haml
@@ -23,20 +23,5 @@
       - if group.searching_location
         %span.tag
           Searching for location
-    %p
-      %strong When:
-      - if group.time?
-        = group.time
-      - else
-        %span.info-not-given
-          not specified
-    %p
-      %strong Where:
-      - if group.address?
-        = group.address
-      - else
-        %span.info-not-given
-          not specified
-    %p
-      %strong Address:
-      = group_location(group)
+
+    = render 'meeting_info', group: group
diff --git a/app/views/groups/show.html.haml b/app/views/groups/show.html.haml
@@ -13,23 +13,8 @@
       - else
         = image_tag('/group-avatar.png', size: "100x100")
       .profile-contact-sub
-        %p
-          %strong 🗓️ When
-          - if @group.time?
-            = @group.time
-          - else
-            %span.info-not-given
-              not specified
-        %p
-          %strong 🏢 Meeting place
-          - if @group.address?
-            = @group.address
-          - else
-            %span.info-not-given
-              not specified
-        %p
-          %strong 🗺️ Address
-          = group_location(@group)
+        = render 'meeting_info', group: @group
+
         - if @group.contact?
           %p
             %strong 📮 Contact

diff --git a/app/views/people/show.html.haml b/app/views/people/show.html.haml
@@ -34,7 +34,7 @@
             = render partial: "shared/website", locals: { object: @person }
 
     .profile-working-on
-      .m-b-l
+      .m-b-l.working-on
         - if @person.working_on?
           %h2 Working on
           %p= markdown(@person.working_on)

diff --git a/spec/features/workshop_coach_spec.rb b/spec/features/workshop_coach_spec.rb
@@ -1,4 +1,3 @@
-
 require 'spec_helper'
 
 feature 'workshop coach' do
@@ -18,7 +17,7 @@ def login_as_user
   end
 
   def coach_text
-    'I am willing to coach at Rails Girls workshops'
+    'I am willing to coach at'
   end
 
   def see_workshop_coach_text