Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate rpm format detection and terminology #3461

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Nov 22, 2024

  1. Rename the rpm format selection macro to %_rpmformat

    %_rpmfilever was always just "something" to get the v6 work going, and
    is simply a bad name for what it does. Call it %_rpmformat which seems
    more obvious and also consistent with the tag we have for it. Update
    related usages to talk about rpmformat consistently.
    
    No functional changes.
    pmatilai committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7d997b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2de52e7 View commit details
    Browse the repository at this point in the history
  3. Add missing documentation for RPMTAG_RPMFORMAT tag

    This should've been in commit af81cb8
    pmatilai committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9ca8e0a View commit details
    Browse the repository at this point in the history
  4. Add tag extension for rpm format version detection

    v6 packages have RPMTAG_RPMFORMAT, but we need to differentiate between
    3 and 4 too in various places. As such this is a rather simple-minded
    heuristic but it at least gives us a central place where to manage that
    detection.
    pmatilai committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4b6f920 View commit details
    Browse the repository at this point in the history
  5. Use RPMTAG_RPMFORMAT for rpm format detection in the signing code

    We now have a nice way to centrally get the format number, use it
    in the signing code instead of the various ad-hoc methods added during
    multi-signature development, and use 'rpmformat' as the variable name
    for easy grepping.
    
    No functional changes.
    pmatilai committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d2a49f2 View commit details
    Browse the repository at this point in the history