Consolidate rpm format detection and terminology #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Meh, forgot tests... I really am not awake today |
%_rpmfilever was always just "something" to get the v6 work going, and is simply a bad name for what it does. Call it %_rpmformat which seems more obvious and also consistent with the tag we have for it. Update related usages to talk about rpmformat consistently. No functional changes.
This should've been in commit af81cb8
v6 packages have RPMTAG_RPMFORMAT, but we need to differentiate between 3 and 4 too in various places. As such this is a rather simple-minded heuristic but it at least gives us a central place where to manage that detection.
We now have a nice way to centrally get the format number, use it in the signing code instead of the various ad-hoc methods added during multi-signature development, and use 'rpmformat' as the variable name for easy grepping. No functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.