Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ARROW_STRIP Marker type #190

Closed
wants to merge 1 commit into from
Closed

Adds ARROW_STRIP Marker type #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions visualization_msgs/msg/Marker.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ uint8 POINTS=8
uint8 TEXT_VIEW_FACING=9
uint8 MESH_RESOURCE=10
uint8 TRIANGLE_LIST=11
uint8 ARROW_STRIP=12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to call this a DIRECTED_LINE_STRIP as that's an already determined thing and we're just adding direction.

There's a few places below that reference LINE_STRIP that should be augmented.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The geometry shares some functionality with ARROW, most notably the appearance and semantics of the scale field. I think ARROW_STRIP makes this connection more explicit, and conveys the same information as DIRECTED_LINE_STRIP in fewer characters.


uint8 ADD=0
uint8 MODIFY=0
Expand Down