-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROS2] image_transport does not support LifecycleNode #108
Comments
Not currently, I believe that this would require some further work to integrate the LifecycleNode. |
I think that using a There is a similar problem with the TF Broadcaster The |
Any updates on this one? |
Any progress on this? It looks like the above issue mention on this has been partially resolved as I am now able to do |
This issue is increasingly relevant as managed lifecycle nodes are used more widely. In my opinion it makes a lot of sense for an image processing node to have lifecycle states, so that we can configure it with image parameters, and then activate / deactivate potentially expensive processing and perception steps through the lifecycle interfaces. More related issues like the ones above will keep arising, and the workarounds are generally less efficient (such as giving up on the image transport layer and just using raw pub / sub of sensor_msg Image instead). Thanks @Rayman for the initiative to solve this. I believe #190 is a great demonstration of the concept of using base interfaces rather than a Is there anything that can be done to encourage these PRs and this issue to be closed? |
I don't know why it takes so long to merge these PRs. It's a relatively simple change. There should be more activity in such a core ros package. |
Any update on this ? we want to use lifecycle nodes in our package, but still blocked by image_transport component. |
@Michael-Equi , Can you advice on how to call image_transport::create_publisher with lifecycle node ? Thanks |
Any update on this? Is this package still being maintained/developed? |
No update that I'm aware of. Generally, I think maintenance is limited to bugfixes and releases. We are always happy to take/review contributions, but I believe that the PR in question here is still in draft? |
Any update on this? |
Looking for an update here as well! |
Hi,
I'm trying to integrate the new image_transport from Crystal in my LifecycleNode, but the functions
image_transport::create_camera_publisher
andimage_transport::create_camera_publisher
only takerclcpp::Node* node
as parameter.Is there any workaround?
The text was updated successfully, but these errors were encountered: