Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt GoalUpdater to update goals as well #4771

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tonynajjar
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@tonynajjar tonynajjar changed the title Adapt GoalUpdater to update goals Adapt GoalUpdater to update goals as well Nov 28, 2024
@tonynajjar
Copy link
Contributor Author

@SteveMacenski as usual, still a draft but what do you think of the idea? Do you have a preference for a standalone node? GoalUpdatedCondition checks both goal and goals in the same node.

@@ -74,16 +84,29 @@ inline BT::NodeStatus GoalUpdater::tick()
}
}

if (!last_goals_received_.poses.empty()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some additional timestamp-checking could be done similarly to how its done for a single goal

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...avior_tree/plugins/decorator/goal_updater_node.cpp 66.66% 4 Missing ⚠️
Files with missing lines Coverage Δ
...avior_tree/plugins/decorator/goal_updater_node.hpp 100.00% <100.00%> (ø)
...avior_tree/plugins/decorator/goal_updater_node.cpp 88.88% <66.66%> (-11.12%) ⬇️

... and 4 files with indirect coverage changes

Signed-off-by: Tony Najjar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant