-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BT.CPP Tree::sleep #4761
Use BT.CPP Tree::sleep #4761
Conversation
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets just move this object to nav2_behavior_tree
where we have our other BT utilities and base functionality
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
@tonynajjar looks like CI doesn't like the linty-freshness of the updates 😆 otherwise, will merge. @facontidavide: This seems like a useful util in BT.CPP - would you accept a PR with it? |
Signed-off-by: Tony Najjar <[email protected]>
CI is still looking for |
@tonynajjar bump the v28 to v29 (there are 3x) in this file: https://github.com/ros-navigation/navigation2/blob/main/.circleci/config.yml We need to fix it first since this will persist to |
Signed-off-by: Tony Najjar <[email protected]>
Basic Info
Description of contribution in a few bullet points
rclcpp::WallRate::sleep
withTree::sleep()
to leverage event-driven treesDescription of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: