Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BT.CPP Tree::sleep #4761

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

tonynajjar
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4736
Primary OS tested on Ubuntu,
Robotic platform tested on Custom simulation
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Replaced BT's engine rclcpp::WallRate::sleep with Tree::sleep() to leverage event-driven trees

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Tony Najjar <[email protected]>
@tonynajjar tonynajjar changed the title Use BT.cpp sleep Use BT.CPP Tree::sleep Nov 22, 2024
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ree/include/nav2_behavior_tree/utils/loop_rate.hpp 77.77% 4 Missing ⚠️
Files with missing lines Coverage Δ
nav2_behavior_tree/src/behavior_tree_engine.cpp 80.00% <100.00%> (ø)
...ree/include/nav2_behavior_tree/utils/loop_rate.hpp 77.77% <77.77%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets just move this object to nav2_behavior_tree where we have our other BT utilities and base functionality

nav2_util/include/nav2_util/bt_loop_rate.hpp Outdated Show resolved Hide resolved
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
@SteveMacenski
Copy link
Member

@tonynajjar looks like CI doesn't like the linty-freshness of the updates 😆

otherwise, will merge.

@facontidavide: This seems like a useful util in BT.CPP - would you accept a PR with it?

Signed-off-by: Tony Najjar <[email protected]>
@tonynajjar
Copy link
Contributor Author

tonynajjar commented Nov 26, 2024

CI is still looking for bt_loop_rate.cpp although it was deleted. I guess some cache issue. Is it safe to merge anyway?

@SteveMacenski
Copy link
Member

@tonynajjar bump the v28 to v29 (there are 3x) in this file: https://github.com/ros-navigation/navigation2/blob/main/.circleci/config.yml

We need to fix it first since this will persist to main if not resolved here first. Yes, looks like a usual caching issue when moving files around. It doesn't like that 😆

Signed-off-by: Tony Najjar <[email protected]>
@SteveMacenski SteveMacenski merged commit dc26fa4 into ros-navigation:main Nov 27, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants