Update RPMI spec #21
Merged
Update RPMI spec #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
April 16, 2024 13:42
Add sub-chapter for Fast Channels support for Performance service group. Signed-off-by: Ley Foon Tan <[email protected]>
GET_PERF_DOMAIN_FAST_CHANNEL_ADDR service call retrieves few fast channel properties, not only address. Rename it. Signed-off-by: Ley Foon Tan <[email protected]>
GET_FAST_CHANNEL_ADDR service call retrieves few properties of fast channel, not only address. Rename it. Also update description for it. Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Update some grammar and wrap text to 80 characters per line. Signed-off-by: Ley Foon Tan <[email protected]>
Note, comment out index.adoc. Without this, bibliography chapter is not generated. Signed-off-by: Ley Foon Tan <[email protected]>
Don't create a sub chapter. Signed-off-by: Ley Foon Tan <[email protected]>
Add cite:[ACPI] reference link. Signed-off-by: Ley Foon Tan <[email protected]>
Add cite:[DT] reference link. Signed-off-by: Ley Foon Tan <[email protected]>
Add cite:[SBI] reference link. Signed-off-by: Ley Foon Tan <[email protected]>
Rephrase and fine-tune some descriptions. Signed-off-by: Ley Foon Tan <[email protected]>
- Update description - Fix grammar Signed-off-by: Ley Foon Tan <[email protected]>
- Minor fix grammar - Wrap the text to 80 character per line - Fine tune some descriptions Signed-off-by: Ley Foon Tan <[email protected]>
lftan
force-pushed
the
update-spec
branch
2 times, most recently
from
a31400f
to
68ca433
Compare
pathakraul
reviewed
Apr 16, 2024
| the system are designated by an integer identifier called clock_id. Clock_id are sequential starting from `0`. | ||
| This service is used to query the number of clocks available in the system. | ||
| All supported clocks in the system are designated by an integer identifier | ||
| called CLOCK_ID. CLOCK_ID are sequential starting from `0`. |
There was a problem hiding this comment.
nit - Last line %s/CLOCK_ID/CLOCK_IDs
pathakraul
reviewed
Apr 16, 2024
| This topology of devices and clock source is dependent on how the system is | ||
| designed and implementation specific. OS can discover this topology through | ||
| firmware tables (DT cite:[DT] / ACPI cite:[ACPI]). | ||
| The topology of the devices and the clock source is dependent on how the system |
There was a problem hiding this comment.
nit - %s/clock source/clock sources. Since there can be multiple
|
There are few nits, but I also have a PR coming so i can take them up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Fast-channel description and some chapters.