Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate remote end steps dfn link #84

Merged

Conversation

svendlarsen
Copy link
Contributor

@svendlarsen svendlarsen commented Oct 9, 2024

Running bikeshed on main yields the following output:

LINE ~837: Multiple possible 'remote end steps' dfn refs.
Arbitrarily chose https://patcg-individual-drafts.github.io/private-aggregation-api/#remote-end-steps
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:private-aggregation-api; type:dfn; text:remote end steps
spec:webdriver2; type:dfn; text:remote end steps
[=remote end steps=]
 ✔  Successfully generated, with 1 linking errors

i.e., bikeshed selects the wrong dfn link for remote end steps.

With this change, running bikeshed produces no warnings and correctly links to the webdriver spec's dfn for remote end steps.


Preview | Diff

@svendlarsen
Copy link
Contributor Author

It looks like CI possibly needs to be updated? It's failing to install bikeshed:

$ pip3 install bikeshed --quiet
    error: externally-managed-environment

@wanderview
Copy link
Collaborator

@jyasskin can you help with the CI problem? Or point us to someone who can?

@jyasskin
Copy link
Collaborator

Probably triggered by actions/runner-images#10636. I've filed w3c/spec-prod#189, and I'll send a PR, but I won't have time to test it.

@jyasskin
Copy link
Collaborator

You can work around the problem by changing

to ubuntu-22.04.

@wanderview
Copy link
Collaborator

@svendlarsen can you rebase this on the tool chain change to see if it passes CI now?

@svendlarsen svendlarsen force-pushed the disambiguate-remote-end-steps-dfn branch from b95525a to de1ad76 Compare October 15, 2024 18:04
@svendlarsen
Copy link
Contributor Author

Yep, success!

@wanderview wanderview merged commit 00cf8bb into privacycg:main Oct 15, 2024
1 check passed
github-actions bot added a commit that referenced this pull request Oct 15, 2024
SHA: 00cf8bb
Reason: push, by wanderview

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@svendlarsen svendlarsen deleted the disambiguate-remote-end-steps-dfn branch October 15, 2024 18:35
amaliev pushed a commit to amaliev/nav-tracking-mitigations that referenced this pull request Oct 18, 2024
amaliev pushed a commit to amaliev/nav-tracking-mitigations that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants