End extended navigation on tab close #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like CI possibly needs to be updated? It's failing to install bikeshed: |
|
LGTM, but hoping @jyasskin can help with the CI issue. |
svendlarsen
force-pushed
the
run-btm-on-tab-close
branch
from
f01c1ab
to
009c742
Compare
|
CI failure should be fixed once #84 is merged. |
svendlarsen
force-pushed
the
run-btm-on-tab-close
branch
from
009c742
to
a09fe80
Compare
It was indeed. |
github-actions bot
added a commit
that referenced
this pull request
Oct 15, 2024
SHA: f647c24 Reason: push, by wanderview Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
amaliev
pushed a commit
to amaliev/nav-tracking-mitigations
that referenced
this pull request
Oct 18, 2024
amaliev
pushed a commit
to amaliev/nav-tracking-mitigations
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that the extended navigation ends when the associated tab is about to close (i.e., top-level traversable is closing).
Fixes #83.
Preview | Diff