Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code_80521D0.s (dungeon_message.c and dungeon_move.c) #233

Merged
merged 34 commits into from
Oct 26, 2024
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
bf99d37
start code_80521D0
DizzyEggg Oct 18, 2024
76ccab8
UnkPrintFieldMsgStruct discovered
DizzyEggg Oct 19, 2024
2442708
document portrait struct
DizzyEggg Oct 20, 2024
c6b04f6
DisplayDungeonDialogue
DizzyEggg Oct 20, 2024
1896d9d
Give names to portrait/dialogue box creating functions
DizzyEggg Oct 20, 2024
570250e
PrintYesNoFieldMessage
DizzyEggg Oct 20, 2024
68dcdce
DisplayDungeonMenuMessage
DizzyEggg Oct 20, 2024
2c2b5ed
DisplayYouReachedDestFloorStr
DizzyEggg Oct 20, 2024
9b118be
make GetTutorialFlag nicer
DizzyEggg Oct 20, 2024
4a4b637
merge with master
DizzyEggg Oct 21, 2024
200744b
sub_8052FB8
DizzyEggg Oct 21, 2024
e69cf64
sub_80532B4
DizzyEggg Oct 21, 2024
38af7bc
sub_805363C and sprite oam memes again urgh
DizzyEggg Oct 21, 2024
c6a0dd2
document some of the message log
DizzyEggg Oct 22, 2024
4bb3c6c
rename 80521D0 to dungeon message
DizzyEggg Oct 22, 2024
d270181
remove code_80521D0.h includes
DizzyEggg Oct 22, 2024
96db7fa
clean dungeon message externs
DizzyEggg Oct 22, 2024
389da1c
sub_80559DC
DizzyEggg Oct 22, 2024
ef2868a
sub_8055DDC
DizzyEggg Oct 23, 2024
902d82f
sub_8055FA0
DizzyEggg Oct 23, 2024
216d931
document called move struct
DizzyEggg Oct 23, 2024
7988b3b
sub_80566F8
DizzyEggg Oct 24, 2024
80e20f5
sub_8056CE8
DizzyEggg Oct 24, 2024
f28ab41
sub_8056F80
DizzyEggg Oct 24, 2024
e935c42
makuhita's dojo unk68 to portraitptr
DizzyEggg Oct 24, 2024
db32603
merge with master
DizzyEggg Oct 24, 2024
5a48a51
commence slaying of the sub_8053704 behemoth
DizzyEggg Oct 24, 2024
5d9b14d
sub_8053704 matched
DizzyEggg Oct 25, 2024
4c4ec10
document some of the use move functions
DizzyEggg Oct 25, 2024
a2bc2f6
move two functions to dungeon_message.c
DizzyEggg Oct 25, 2024
b0f1f8a
new file - dungeon_move.c and clean-up
DizzyEggg Oct 25, 2024
848d0a0
move some const data to dungeon move/message
DizzyEggg Oct 25, 2024
83df45a
r0 to pokemon
DizzyEggg Oct 26, 2024
c41b7f0
Use move constants in UseMoveAgainstTargets
DizzyEggg Oct 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions asm/code_2.s
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ QuickSave:
movs r1, 0
movs r2, 0
movs r3, 0x20
bl xxx_info_box_80141B4
bl CreateDialogueBoxAndPortrait
b _08000892
.align 2, 0
_080007AC: .4byte gUnknown_2026E4E
Expand Down Expand Up @@ -234,7 +234,7 @@ _08000822:
movs r1, 0
movs r2, 0
ldr r3, _08000838
bl xxx_info_box_80141B4
bl CreateDialogueBoxAndPortrait
movs r6, 0x3C
movs r4, 0x1
b _08000892
Expand All @@ -248,7 +248,7 @@ _0800083C:
movs r1, 0
movs r2, 0
movs r3, 0
bl xxx_info_box_80141B4
bl CreateDialogueBoxAndPortrait
movs r4, 0x3
b _08000892
.align 2, 0
Expand All @@ -258,7 +258,7 @@ _08000854:
movs r1, 0
movs r2, 0
ldr r3, _08000868
bl xxx_info_box_80141B4
bl CreateDialogueBoxAndPortrait
_08000860:
movs r4, 0x2
b _08000892
Expand Down Expand Up @@ -358,7 +358,7 @@ _08000934:
movs r1, 0
movs r2, 0
movs r3, 0x20
bl xxx_info_box_80141B4
bl CreateDialogueBoxAndPortrait
movs r4, 0x2
b _080009A2
.align 2, 0
Expand All @@ -374,7 +374,7 @@ _08000952:
ldr r3, _08000964
movs r1, 0
movs r2, 0
bl xxx_info_box_80141B4
bl CreateDialogueBoxAndPortrait
_0800095C:
movs r4, 0x1
b _080009A2
Expand Down
4 changes: 2 additions & 2 deletions asm/code_800F990.s
Original file line number Diff line number Diff line change
Expand Up @@ -2325,9 +2325,9 @@ sub_8010C10:
str r1, [sp, 0x10]
movs r1, 0
movs r3, 0
bl sub_8014248
bl CreateMenuDialogueBoxAndPortrait
_08010C2C:
bl xxx_draw_string_80144C4
bl DrawDialogueBoxString
bl sub_8010960
add r0, sp, 0x14
bl sub_80144A4
Expand Down
12 changes: 6 additions & 6 deletions asm/code_80140DC.s
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

.text

thumb_func_start sub_8014248
sub_8014248:
thumb_func_start CreateMenuDialogueBoxAndPortrait
CreateMenuDialogueBoxAndPortrait:
push {r4-r7,lr}
mov r7, r10
mov r6, r9
Expand Down Expand Up @@ -277,7 +277,7 @@ _08014480:
pop {r4-r7}
pop {r0}
bx r0
thumb_func_end sub_8014248
thumb_func_end CreateMenuDialogueBoxAndPortrait

thumb_func_start sub_8014490
sub_8014490:
Expand Down Expand Up @@ -311,8 +311,8 @@ _080144BC: .4byte gUnknown_202EC1C
_080144C0: .4byte gUnknown_202E744
thumb_func_end sub_80144A4

thumb_func_start xxx_draw_string_80144C4
xxx_draw_string_80144C4:
thumb_func_start DrawDialogueBoxString
DrawDialogueBoxString:
push {r4-r7,lr}
mov r7, r10
mov r6, r9
Expand Down Expand Up @@ -1018,7 +1018,7 @@ _08014A72:
bx r0
.align 2, 0
_08014A84: .4byte gUnknown_202E744
thumb_func_end xxx_draw_string_80144C4
thumb_func_end DrawDialogueBoxString

thumb_func_start sub_8014A88
sub_8014A88:
Expand Down
2 changes: 1 addition & 1 deletion asm/code_8040094.s
Original file line number Diff line number Diff line change
Expand Up @@ -1728,7 +1728,7 @@ _08040E6E:
ldr r0, _08040ECC
ldr r1, [r0]
adds r0, r6, 0
bl SendMessage
bl TryDisplayDungeonLoggableMessage
movs r1, 0xD2
lsls r1, 1
adds r0, r6, 0
Expand Down
26 changes: 13 additions & 13 deletions asm/code_8045A00.s
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ _08045FAC:
_08045FD0:
ldr r1, [r0]
adds r0, r7, 0
bl SendMessage
bl TryDisplayDungeonLoggableMessage
b _08045FF2
.align 2, 0
_08045FDC: .4byte 0x00ff0008
Expand All @@ -288,10 +288,10 @@ _08045FE8:
ldr r0, _08045FFC
ldr r1, [r0]
adds r0, r7, 0
bl SendMessage
bl TryDisplayDungeonLoggableMessage
_08045FF2:
ldrb r0, [r5, 0x2]
bl HandleOnPickupTutorial
bl TryDisplayItemPickupTutorialMessage
b _080460E0
.align 2, 0
_08045FFC: .4byte gPickedUpItemToolbox
Expand Down Expand Up @@ -336,7 +336,7 @@ _0804602E:
_08046048:
ldr r1, [r0]
adds r0, r7, 0
bl SendMessage
bl TryDisplayDungeonLoggableMessage
b _080460E0
.align 2, 0
_08046054: .4byte gFormatItems
Expand Down Expand Up @@ -379,7 +379,7 @@ _08046094:
_080460AC:
ldr r1, [r0]
adds r0, r7, 0
bl SendMessage
bl TryDisplayDungeonLoggableMessage
b _080460DA
.align 2, 0
_080460B8: .4byte gAvailablePokemonNames
Expand All @@ -394,10 +394,10 @@ _080460C0:
ldr r0, _080460F4
ldr r1, [r0]
adds r0, r7, 0
bl SendMessage
bl TryDisplayDungeonLoggableMessage
_080460DA:
ldrb r0, [r5, 0x2]
bl HandleOnPickupTutorial
bl TryDisplayItemPickupTutorialMessage
_080460E0:
add sp, 0xB8
pop {r3-r5}
Expand Down Expand Up @@ -996,7 +996,7 @@ sub_804652C:
ldr r0, _080465A4
ldr r1, [r0]
mov r0, r10
bl SendMessage
bl TryDisplayDungeonLoggableMessage
mov r0, r9
ldrb r1, [r0]
movs r0, 0x1
Expand Down Expand Up @@ -1156,7 +1156,7 @@ _080466B6:
ldr r2, [r0]
mov r0, r10
mov r1, sp
bl sub_8052364
bl TryDisplayDungeonLoggableMessage5
b _0804671E
.align 2, 0
_080466C4: .4byte gItemFellOutOfSight
Expand Down Expand Up @@ -1202,7 +1202,7 @@ _0804670C:
ldr r2, [r0]
mov r0, r10
mov r1, sp
bl sub_8052364
bl TryDisplayDungeonLoggableMessage5
_0804671E:
add sp, 0x10
pop {r3-r5}
Expand Down Expand Up @@ -1721,7 +1721,7 @@ _08046B0A:
ldr r4, _08046B38
add r4, sp
ldr r0, [r4]
bl SendMessage
bl TryDisplayDungeonLoggableMessage
b _08046C7C
.align 2, 0
_08046B2C: .4byte 0x0000052c
Expand All @@ -1734,7 +1734,7 @@ _08046B3C:
ldr r5, _08046B50
add r5, sp
ldr r0, [r5]
bl SendMessage
bl TryDisplayDungeonLoggableMessage
b _08046C7C
.align 2, 0
_08046B4C: .4byte gItemLost
Expand All @@ -1748,7 +1748,7 @@ _08046B54:
ldr r2, _08046C94
add r2, sp
ldr r0, [r2]
bl SendMessage
bl TryDisplayDungeonLoggableMessage
_08046B68:
movs r3, 0
mov r9, r3
Expand Down
14 changes: 7 additions & 7 deletions asm/code_8046CE4.s
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ _08047462:
ldr r2, [r0]
mov r0, r9
adds r1, r4, 0
bl sub_80522F4
bl TryDisplayDungeonLoggableMessage3
mov r0, r9
adds r1, r4, 0
bl TrySendImmobilizeSleepEndMsg
Expand Down Expand Up @@ -475,7 +475,7 @@ _080474E2:
ldr r2, [r0]
mov r0, r9
adds r1, r4, 0
bl sub_80522F4
bl TryDisplayDungeonLoggableMessage3
b _08047524
.align 2, 0
_0804750C: .4byte gAvailablePokemonNames
Expand All @@ -486,7 +486,7 @@ _08047518:
ldr r2, [r0]
mov r0, r9
adds r1, r4, 0
bl sub_80522F4
bl TryDisplayDungeonLoggableMessage3
_08047524:
adds r5, 0x8
subs r6, 0x1
Expand Down Expand Up @@ -552,7 +552,7 @@ _08047596:
ldr r0, _080475C0
ldr r1, [r0]
mov r0, r9
bl SendMessage
bl TryDisplayDungeonLoggableMessage
_080475A8:
movs r3, 0x90
lsls r3, 2
Expand Down Expand Up @@ -924,7 +924,7 @@ _0804786E:
ldr r2, [r0]
ldr r0, [sp, 0x10]
adds r1, r5, 0
bl sub_80522F4
bl TryDisplayDungeonLoggableMessage3
ldr r0, [sp, 0x10]
adds r1, r5, 0
bl TrySendImmobilizeSleepEndMsg
Expand Down Expand Up @@ -962,7 +962,7 @@ _080478DC:
ldr r2, [r0]
ldr r0, [sp, 0x10]
adds r1, r5, 0
bl sub_80522F4
bl TryDisplayDungeonLoggableMessage3
b _08047900
.align 2, 0
_080478F0: .4byte gUnknown_80F9510
Expand All @@ -971,7 +971,7 @@ _080478F4:
ldr r2, [r0]
ldr r0, [sp, 0x10]
adds r1, r5, 0
bl sub_80522F4
bl TryDisplayDungeonLoggableMessage3
_08047900:
movs r2, 0x1
str r2, [sp, 0x20]
Expand Down
Loading