Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code_80521D0.s (dungeon_message.c and dungeon_move.c) #233

Merged
merged 34 commits into from
Oct 26, 2024
Merged

code_80521D0.s (dungeon_message.c and dungeon_move.c) #233

merged 34 commits into from
Oct 26, 2024

Conversation

DizzyEggg
Copy link
Contributor

WIP

@DizzyEggg DizzyEggg changed the title code_80521D0.s code_80521D0.s (dungeon_message.s) Oct 22, 2024
@DizzyEggg
Copy link
Contributor Author

I decided to rename the file to dungeon_message.c as it's all dungeon string related functions.

I also named/renamed bunch of stuff, so any critique is welcome 😄

@DizzyEggg DizzyEggg marked this pull request as ready for review October 25, 2024 20:48
@DizzyEggg DizzyEggg changed the title code_80521D0.s (dungeon_message.s) code_80521D0.s (dungeon_message.c and dungeon_move.c) Oct 25, 2024
@DizzyEggg
Copy link
Contributor Author

Ready for review.
Two new files created from code_80521D0.s. Lots of renaming, documentation, EWRAM/const variables moving and clean-up.

@DizzyEggg
Copy link
Contributor Author

Reviews applied

@AnonymousRandomPerson AnonymousRandomPerson merged commit d8329f7 into pret:master Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethBarberee SethBarberee SethBarberee left review comments

@AnonymousRandomPerson AnonymousRandomPerson AnonymousRandomPerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DizzyEggg @AnonymousRandomPerson @SethBarberee