fix to #1553 if "_api/Web/SiteUsers" then the user is always added to the SiteUsers instead of the SPOGroup #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SiteUsers and not to the SPO-Group
|
Thanks @czullu for the fix , ran into the same issue in PnP PowerShell as well where we use the same code. |
jansenbe
added a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jansenbe after the fix #1553 i was not able to add users to SharePoint Groups anymore. Output did show that await spGroup.AddUserAsync("i:0#.f|membership|xyz"); would send a post request to SiteUsers instead of the SPOGroup and therefore the user does not get added.