Fixed regression introduced by 29a64be and was partly fixed by #1577

src/sdk/CHANGELOG.md

@@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Fixed to the issue where users were getting added to User Info list instead of a SharePoint group. #1577 [czullu - Christian Zuellig]
 - Modern Page Title in OneColumnFullWithSection also allowed in TEAMCHANNEL Sites #1564 [czullu - Christian Zuellig]
 - Pages that removed the full width section and the banner web part and therefore have no page title anymore do not get a page title when being updated #1550 [jansenbe - Bert Jansen]
+- Fixed regression introduced by https://github.com/pnp/pnpcore/commit/29a64bef0cfedbb3a0f7b64386b64d54793d7d71 and was partly fixed by #1577 [jansenbe - Bert Jansen]
 
 ## [1.14]
 

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00000.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"3e0828a0-5004-3000-e1e0-edbfc1b614d1","SPClientServiceRequestDuration":"9","X-SharePointHealthScore":"0","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022RegionalSettings\u0022:{\u0022TimeZone\u0022:{\u0022Description\u0022:\u0022(UTC-08:00) Pacific Time (US and Canada)\u0022,\u0022Id\u0022:13,\u0022Information\u0022:{\u0022Bias\u0022:480,\u0022DaylightBias\u0022:-60,\u0022StandardBias\u0022:0}},\u0022AdjustHijriDays\u0022:0,\u0022AlternateCalendarType\u0022:0,\u0022AM\u0022:\u0022AM\u0022,\u0022CalendarType\u0022:1,\u0022Collation\u0022:25,\u0022CollationLCID\u0022:2070,\u0022DateFormat\u0022:0,\u0022DateSeparator\u0022:\u0022/\u0022,\u0022DecimalSeparator\u0022:\u0022.\u0022,\u0022DigitGrouping\u0022:\u00223;0\u0022,\u0022FirstDayOfWeek\u0022:0,\u0022FirstWeekOfYear\u0022:0,\u0022IsEastAsia\u0022:false,\u0022IsRightToLeft\u0022:false,\u0022IsUIRightToLeft\u0022:false,\u0022ListSeparator\u0022:\u0022,\u0022,\u0022LocaleId\u0022:1033,\u0022NegativeSign\u0022:\u0022-\u0022,\u0022NegNumberMode\u0022:1,\u0022PM\u0022:\u0022PM\u0022,\u0022PositiveSign\u0022:\u0022\u0022,\u0022ShowWeeks\u0022:false,\u0022ThousandSeparator\u0022:\u0022,\u0022,\u0022Time24\u0022:false,\u0022TimeMarkerPosition\u0022:0,\u0022TimeSeparator\u0022:\u0022:\u0022,\u0022WorkDayEndHour\u0022:1020,\u0022WorkDays\u0022:62,\u0022WorkDayStartHour\u0022:480},\u0022Id\u0022:\u00222c99a486-d6c9-4a4b-8d6f-a9faa364c92c\u0022,\u0022Url\u0022:\u0022https://bertonline.sharepoint.com/sites/prov-2\u0022}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"a71165a1-c0a6-a000-503f-c9bdde30b5b0","SPClientServiceRequestDuration":"19","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022RegionalSettings\u0022:{\u0022TimeZone\u0022:{\u0022Description\u0022:\u0022(UTC-08:00) Pacific Time (US and Canada)\u0022,\u0022Id\u0022:13,\u0022Information\u0022:{\u0022Bias\u0022:480,\u0022DaylightBias\u0022:-60,\u0022StandardBias\u0022:0}},\u0022AdjustHijriDays\u0022:0,\u0022AlternateCalendarType\u0022:0,\u0022AM\u0022:\u0022AM\u0022,\u0022CalendarType\u0022:1,\u0022Collation\u0022:25,\u0022CollationLCID\u0022:2070,\u0022DateFormat\u0022:0,\u0022DateSeparator\u0022:\u0022/\u0022,\u0022DecimalSeparator\u0022:\u0022.\u0022,\u0022DigitGrouping\u0022:\u00223;0\u0022,\u0022FirstDayOfWeek\u0022:0,\u0022FirstWeekOfYear\u0022:0,\u0022IsEastAsia\u0022:false,\u0022IsRightToLeft\u0022:false,\u0022IsUIRightToLeft\u0022:false,\u0022ListSeparator\u0022:\u0022,\u0022,\u0022LocaleId\u0022:1033,\u0022NegativeSign\u0022:\u0022-\u0022,\u0022NegNumberMode\u0022:1,\u0022PM\u0022:\u0022PM\u0022,\u0022PositiveSign\u0022:\u0022\u0022,\u0022ShowWeeks\u0022:false,\u0022ThousandSeparator\u0022:\u0022,\u0022,\u0022Time24\u0022:false,\u0022TimeMarkerPosition\u0022:0,\u0022TimeSeparator\u0022:\u0022:\u0022,\u0022WorkDayEndHour\u0022:1020,\u0022WorkDays\u0022:62,\u0022WorkDayStartHour\u0022:480},\u0022Id\u0022:\u00222c99a486-d6c9-4a4b-8d6f-a9faa364c92c\u0022,\u0022Url\u0022:\u0022https://bertonline.sharepoint.com/sites/prov-2\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00001.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"3e0828a0-5014-3000-f132-875ab17ea864","SPClientServiceRequestDuration":"9","X-SharePointHealthScore":"3","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022GroupId\u0022:\u0022d40d729b-df60-4b57-ac8f-102595090e0a\u0022,\u0022Id\u0022:\u0022f92f9e40-1110-43ef-aa0e-0822e13fb7ba\u0022}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"a71165a1-30b6-a000-503f-c411a8cc63ae","SPClientServiceRequestDuration":"14","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022GroupId\u0022:\u0022d40d729b-df60-4b57-ac8f-102595090e0a\u0022,\u0022Id\u0022:\u0022f92f9e40-1110-43ef-aa0e-0822e13fb7ba\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00002.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"3e0828a0-b01d-3000-e1e0-e9de56334b84","SPClientServiceRequestDuration":"10","X-SharePointHealthScore":"2","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022Id\u0022:11,\u0022IsHiddenInUI\u0022:false,\u0022LoginName\u0022:\u0022i:0#.f|membership|[email protected]\u0022,\u0022Title\u0022:\u0022Bert Jansen (Cloud)\u0022,\u0022PrincipalType\u0022:1,\u0022Email\u0022:\u0022[email protected]\u0022,\u0022Expiration\u0022:\u0022\u0022,\u0022IsEmailAuthenticationGuestUser\u0022:false,\u0022IsShareByEmailGuestUser\u0022:false,\u0022IsSiteAdmin\u0022:true,\u0022UserId\u0022:{\u0022NameId\u0022:\u00221003000084e4ff61\u0022,\u0022NameIdIssuer\u0022:\u0022urn:federation:microsoftonline\u0022},\u0022UserPrincipalName\u0022:\u0022[email protected]\u0022}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"a81165a1-b033-a000-503f-ccc784acf76c","SPClientServiceRequestDuration":"9","X-SharePointHealthScore":"0","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022Id\u0022:11,\u0022IsHiddenInUI\u0022:false,\u0022LoginName\u0022:\u0022i:0#.f|membership|[email protected]\u0022,\u0022Title\u0022:\u0022Bert Jansen (Cloud)\u0022,\u0022PrincipalType\u0022:1,\u0022Email\u0022:\u0022[email protected]\u0022,\u0022Expiration\u0022:\u0022\u0022,\u0022IsEmailAuthenticationGuestUser\u0022:false,\u0022IsShareByEmailGuestUser\u0022:false,\u0022IsSiteAdmin\u0022:true,\u0022UserId\u0022:{\u0022NameId\u0022:\u00221003000084e4ff61\u0022,\u0022NameIdIssuer\u0022:\u0022urn:federation:microsoftonline\u0022},\u0022UserPrincipalName\u0022:\u0022[email protected]\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00003.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":201,"Headers":{"SPRequestGuid":"3f0828a0-20e4-3000-e1e0-e60f669ad9d1","SPClientServiceRequestDuration":"160","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022Id\u0022:11,\u0022IsHiddenInUI\u0022:false,\u0022LoginName\u0022:\u0022i:0#.f|membership|[email protected]\u0022,\u0022Title\u0022:\u0022Bert Jansen (Cloud)\u0022,\u0022PrincipalType\u0022:1,\u0022Email\u0022:\u0022[email protected]\u0022,\u0022Expiration\u0022:\u0022\u0022,\u0022IsEmailAuthenticationGuestUser\u0022:false,\u0022IsShareByEmailGuestUser\u0022:false,\u0022IsSiteAdmin\u0022:false,\u0022UserId\u0022:{\u0022NameId\u0022:\u00221003000084e4ff61\u0022,\u0022NameIdIssuer\u0022:\u0022urn:federation:microsoftonline\u0022},\u0022UserPrincipalName\u0022:\u0022[email protected]\u0022}"}
+{"IsSuccessStatusCode":true,"StatusCode":201,"Headers":{"SPRequestGuid":"ab1165a1-107d-a000-503f-c07a758b441c","SPClientServiceRequestDuration":"250","X-SharePointHealthScore":"2","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022Id\u0022:11,\u0022IsHiddenInUI\u0022:false,\u0022LoginName\u0022:\u0022i:0#.f|membership|[email protected]\u0022,\u0022Title\u0022:\u0022Bert Jansen (Cloud)\u0022,\u0022PrincipalType\u0022:1,\u0022Email\u0022:\u0022[email protected]\u0022,\u0022Expiration\u0022:\u0022\u0022,\u0022IsEmailAuthenticationGuestUser\u0022:false,\u0022IsShareByEmailGuestUser\u0022:false,\u0022IsSiteAdmin\u0022:false,\u0022UserId\u0022:{\u0022NameId\u0022:\u00221003000084e4ff61\u0022,\u0022NameIdIssuer\u0022:\u0022urn:federation:microsoftonline\u0022},\u0022UserPrincipalName\u0022:\u0022[email protected]\u0022}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00004.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"400828a0-405b-3000-e1e0-eee0e0c89d02","SPClientServiceRequestDuration":"12","X-SharePointHealthScore":"0","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022value\u0022:[{\u0022BasePermissions\u0022:{\u0022High\u0022:\u00222147483647\u0022,\u0022Low\u0022:\u00224294967295\u0022},\u0022Description\u0022:\u0022Has full control.\u0022,\u0022Hidden\u0022:false,\u0022Id\u0022:1073741829,\u0022Name\u0022:\u0022Full Control\u0022,\u0022Order\u0022:1,\u0022RoleTypeKind\u0022:5}]}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"ac1165a1-300b-a000-503f-cabf3a205d13","SPClientServiceRequestDuration":"16","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022value\u0022:[{\u0022BasePermissions\u0022:{\u0022High\u0022:\u00222147483647\u0022,\u0022Low\u0022:\u00224294967295\u0022},\u0022Description\u0022:\u0022Has full control.\u0022,\u0022Hidden\u0022:false,\u0022Id\u0022:1073741829,\u0022Name\u0022:\u0022Full Control\u0022,\u0022Order\u0022:1,\u0022RoleTypeKind\u0022:5}]}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00005.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"400828a0-1066-3000-f132-821ca363631b","SPClientServiceRequestDuration":"114","X-SharePointHealthScore":"2","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022odata.null\u0022:true}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"ac1165a1-a014-a000-503f-c260ee0b78f7","SPClientServiceRequestDuration":"42","X-SharePointHealthScore":"2","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022odata.null\u0022:true}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00006.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"400828a0-f092-3000-e1e0-e57836593869","SPClientServiceRequestDuration":"76","X-SharePointHealthScore":"3","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022value\u0022:[{\u0022RoleDefinitionBindings\u0022:[{\u0022BasePermissions\u0022:{\u0022High\u0022:\u00222147483647\u0022,\u0022Low\u0022:\u00224294967295\u0022},\u0022Description\u0022:\u0022Has full control.\u0022,\u0022Hidden\u0022:false,\u0022Id\u0022:1073741829,\u0022Name\u0022:\u0022Full Control\u0022,\u0022Order\u0022:1,\u0022RoleTypeKind\u0022:5}],\u0022PrincipalId\u0022:11}]}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"ac1165a1-d040-a000-b712-be3d21cc69d9","SPClientServiceRequestDuration":"19","X-SharePointHealthScore":"2","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022value\u0022:[{\u0022RoleDefinitionBindings\u0022:[{\u0022BasePermissions\u0022:{\u0022High\u0022:\u00222147483647\u0022,\u0022Low\u0022:\u00224294967295\u0022},\u0022Description\u0022:\u0022Has full control.\u0022,\u0022Hidden\u0022:false,\u0022Id\u0022:1073741829,\u0022Name\u0022:\u0022Full Control\u0022,\u0022Order\u0022:1,\u0022RoleTypeKind\u0022:5}],\u0022PrincipalId\u0022:11}]}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00007.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"410828a0-a0c7-3000-f132-88b3337c1006","SPClientServiceRequestDuration":"18","X-SharePointHealthScore":"3","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022value\u0022:[{\u0022RoleDefinitionBindings\u0022:[{\u0022BasePermissions\u0022:{\u0022High\u0022:\u00222147483647\u0022,\u0022Low\u0022:\u00224294967295\u0022},\u0022Description\u0022:\u0022Has full control.\u0022,\u0022Hidden\u0022:false,\u0022Id\u0022:1073741829,\u0022Name\u0022:\u0022Full Control\u0022,\u0022Order\u0022:1,\u0022RoleTypeKind\u0022:5}],\u0022PrincipalId\u0022:11}]}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"ac1165a1-e094-a000-503f-c77108c5cbd4","SPClientServiceRequestDuration":"27","X-SharePointHealthScore":"0","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022value\u0022:[{\u0022RoleDefinitionBindings\u0022:[{\u0022BasePermissions\u0022:{\u0022High\u0022:\u00222147483647\u0022,\u0022Low\u0022:\u00224294967295\u0022},\u0022Description\u0022:\u0022Has full control.\u0022,\u0022Hidden\u0022:false,\u0022Id\u0022:1073741829,\u0022Name\u0022:\u0022Full Control\u0022,\u0022Order\u0022:1,\u0022RoleTypeKind\u0022:5}],\u0022PrincipalId\u0022:11}]}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00008.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"410828a0-60cf-3000-e1e0-e0b2ba049972","SPClientServiceRequestDuration":"37","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022odata.null\u0022:true}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"ac1165a1-509e-a000-503f-cd30da52a9f0","SPClientServiceRequestDuration":"47","X-SharePointHealthScore":"0","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022odata.null\u0022:true}"}

src/sdk/PnP.Core.Test/SharePoint/MockData/WebTests/AddUserToWebTest-0-00009.response.json

@@ -1 +1 @@
-{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"410828a0-90f2-3000-f132-8892eba25903","SPClientServiceRequestDuration":"16","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022value\u0022:[]}"}
+{"IsSuccessStatusCode":true,"StatusCode":200,"Headers":{"SPRequestGuid":"ac1165a1-70ce-a000-b712-b782fd22472f","SPClientServiceRequestDuration":"21","X-SharePointHealthScore":"1","X-SP-SERVERSTATE":"ReadOnly=0"},"Response":"{\u0022value\u0022:[]}"}

src/sdk/PnP.Core/Model/Security/Internal/SharePointUser.cs

@@ -28,7 +28,16 @@ public SharePointUser()
                         LoginName
                     };
                     var jsonBody = JsonSerializer.Serialize(body);
-                    return new ApiCall(entity.SharePointGet, ApiType.SPORest, jsonBody);
+                    
+                    if (entity.Target == typeof(Web))
+                    {
+                        return new ApiCall("_api/Web/SiteUsers", ApiType.SPORest, jsonBody);
+                    }
+                    else
+                    {
+                        return new ApiCall(entity.SharePointGet, ApiType.SPORest, jsonBody);
+                    }
+                    
 
                 }).ConfigureAwait(false);
             };