Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Rule5-43.md #1539

Open
wants to merge 5 commits into
base: feature/ashrae9012022
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions docs/section5/Rule5-43.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@

# Envelope - Rule 5-43

**Rule ID:** 5-43
**Rule Description:** Automatic fenestration shading devices shall not be modeled in the Baseline.
KarenWGard marked this conversation as resolved.
Show resolved Hide resolved
**Rule Assertion:** Baseline RMD = expected value
**Appendix G Section:** Section G3.1-5(d) Building Envelope Modeling Requirements for the Baseline building
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I am going crazy, I don't see where it addresses automatic shading devices for the baseline in the Baseline Building Performance column in d.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ASHRAE 2022

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still in 90.1 2022 not seeing anything about shading in Section G3.1-5(d) Building Envelope Modeling Requirements for the Baseline building

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's actually 5f, but it's there. I updated the reference:

image

**Mandatory Rule:** True

**Manual Check:** None
**Evaluation Context:** Each SubSurface
**Function Call:**

NONE

## Applicability Check:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There does not appear to be any applicability checks in the "Applicability Check" section. I don't understand why this loop is in this section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from your comments, I think that you're suggesting that the rule should be evaluated at the building level, not the subsurface level. This makes sense. I updated the rule. & added an applicability check that the subsurfaces be exterior surfaces

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole section I think can be simplified to if len(B_RMD...subsurfaces) == 0: NOT APPLICABLE

- look at each zone: `for zone in B_RMD...zones:`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the point of the nested loops. Why not start with for subsurface in B_RMD...subsurfaces"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from your comments, I think that you're suggesting that the rule should be evaluated at the building level, not the subsurface level. This makes sense. I updated the rule. & added an applicability check that the subsurfaces be exterior surfaces

- look at each surface: `for surface in zone.surfaces:`
- look at each subsurface: `for sub_surface in surface.subsurfaces: CONTINUE TO RULE LOGIC`

## Rule Logic:
- create a variable automatic_shades_modeled and set it to false: `automatic_shades_modeled = false`
- check whether the subsurface has the data element has_automatic_shades: `if sub_surface.has_automatic_shades != NULL:`
- set automatic_shades_modeled to sub_surface.has_atomatic_shades: `automatic_shades_modeled = sub_surface.has_automatic_shades`

**Rule Assertion:**
- Case 1: If the baseline subsurface does not have shading devices, then pass: `if not automatic_shades_modeled: PASS`
- Case 2: If the baseline subsurface has shading devices, then fail: `if automatic_shades_modeled: FAIL`


**Notes:**


**[Back](../_toc.md)**


Loading