Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Rule5-43.md #1539
base: feature/ashrae9012022
Are you sure you want to change the base?
Create Rule5-43.md #1539
Changes from 2 commits
05b3e86
fee626e
feaacaf
0149a8a
9afca49
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I am going crazy, I don't see where it addresses automatic shading devices for the baseline in the Baseline Building Performance column in d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ASHRAE 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still in 90.1 2022 not seeing anything about shading in Section G3.1-5(d) Building Envelope Modeling Requirements for the Baseline building
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's actually 5f, but it's there. I updated the reference:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There does not appear to be any applicability checks in the "Applicability Check" section. I don't understand why this loop is in this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from your comments, I think that you're suggesting that the rule should be evaluated at the building level, not the subsurface level. This makes sense. I updated the rule. & added an applicability check that the subsurfaces be exterior surfaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole section I think can be simplified to
if len(B_RMD...subsurfaces) == 0: NOT APPLICABLE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the point of the nested loops. Why not start with
for subsurface in B_RMD...subsurfaces"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from your comments, I think that you're suggesting that the rule should be evaluated at the building level, not the subsurface level. This makes sense. I updated the rule. & added an applicability check that the subsurfaces be exterior surfaces