Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Rule5-43.md #1539

Open
wants to merge 5 commits into
base: feature/ashrae9012022
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions docs/section5/Rule5-43.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@

# Envelope - Rule 5-43

**Mandatory Rule:** True
**Rule ID:** 5-43
**Rule Description:** Automatic fenestration shading devices shall not be modeled in the Baseline.
KarenWGard marked this conversation as resolved.
Show resolved Hide resolved
**Rule Assertion:** Baseline RMD = expected value
**Appendix G Section:** Section G3.1-5(f) Building Envelope Modeling Requirements for the Baseline building

**Manual Check:** None
**Evaluation Context:** Each Building
**Function Call:**


## Applicability Check:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There does not appear to be any applicability checks in the "Applicability Check" section. I don't understand why this loop is in this section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from your comments, I think that you're suggesting that the rule should be evaluated at the building level, not the subsurface level. This makes sense. I updated the rule. & added an applicability check that the subsurfaces be exterior surfaces

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole section I think can be simplified to if len(B_RMD...subsurfaces) == 0: NOT APPLICABLE

- look at each zone: `for building in B_RMD.buildings:`
- look at each zone: `for zone in building...zones:`
- look at each surface: `for surface in zone.surfaces:`
- check if the surface is an exterior surface type: `if surface.adjacent_to == "EXTERIOR":`
- look at each subsurface: `for sub_surface in surface.subsurfaces: CONTINUE TO RULE LOGIC`
- if the code reaches here without going to the rule logic, the building has no exterior subsurfaces and the rule is not applicable: `NOT APPLICABLE`

## Rule Logic:
- create a list automatic_shades_modeled and initialize it as an empty list: `automatic_shades_modeled = []`
- look at each zone: `for zone in B_RMD...zones:`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing is being referenced from the zone or surface - we can go directly to subsurface

- look at each surface: `for surface in zone.surfaces:`
- check if the surface is an exterior surface type: `if surface.adjacent_to == "EXTERIOR":`
- look at each subsurface: `for sub_surface in surface.subsurfaces:`
- check whether the subsurface has the data element has_automatic_shades: `if sub_surface.has_automatic_shades != NULL:`
- if the window has automatic shades, append this sub_surface id to the list automatic_shades_modeled: `if sub_surface.has_automatic_shades: automatic_shades_modeled.append(sub_surface.id)`
- GO TO RULE ASSERTION

**Rule Assertion:**
- Case 1: If the baseline does not have shading devices, the list automatic_shades_modeled will be empty, PASS: `if len(automatic_shades_modeled) == 0: PASS`
- Case 2: Otherwise FAIL: `else: FAIL`


**Notes:**


**[Back](../_toc.md)**


Loading