-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: fix upstream switch job test #11745
Open
GMHDBJD
wants to merge
12
commits into
pingcap:master
Choose a base branch
from
GMHDBJD:fixSourceChange
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−19
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cce84f6
dm: add test
GMHDBJD a92886b
dm: add test
GMHDBJD dd2e62d
dm: add test
GMHDBJD a54c2c3
dm: add test
GMHDBJD df739f7
dm: add test
GMHDBJD ff2d5db
dm: add test
GMHDBJD 9e75d18
dm: add test
GMHDBJD 673d11c
dm: add test
GMHDBJD 85784dd
dm: add test
GMHDBJD 1aaea0a
dm: add test
GMHDBJD 8d6f965
dm: add test
GMHDBJD a86930c
remove tmate
GMHDBJD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,8 @@ jobs: | |
|
||
- name: Setup containers | ||
run: | | ||
sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose | ||
sudo chmod +x /usr/local/bin/docker-compose | ||
docker-compose -f ./dm/tests/upstream_switch/docker-compose.yml up -d | ||
|
||
- name: Run test cases | ||
|
@@ -73,12 +75,15 @@ jobs: | |
path: | | ||
./logs | ||
|
||
# send Slack notify if failed. | ||
# NOTE: With the exception of `GITHUB_TOKEN`, secrets are not passed to the runner when a workflow is triggered from a forked repository. | ||
- name: Slack notification | ||
# Send feishu notification if failed. | ||
- name: Feishu notification | ||
continue-on-error: true | ||
uses: foxundermoon/feishu-action@v2 | ||
if: ${{ failure() }} | ||
env: | ||
SLACK_WEBHOOK: ${{ secrets.SLACK_NOTIFY }} | ||
uses: Ilshidur/[email protected] | ||
with: | ||
args: "upstream-switch job failed, see https://github.com/pingcap/tiflow/actions/runs/{{ GITHUB_RUN_ID }}" | ||
url: ${{ secrets.ENGINE_FEISHU_NOTIFY_URL }} | ||
msg_type: text | ||
content: | | ||
text: | | ||
dm upstream switch job failed, see https://github.com/pingcap/tiflow/actions/runs/${{ github.run_id }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it overwrite the DM_MASTER_EXTRA_ARG set by GitHub secret?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just same with other test
tiflow/dm/tests/run.sh
Line 6 in 68c22f3