-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: fix upstream switch job test #11745
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11745 +/- ##
================================================
+ Coverage 55.1510% 55.1984% +0.0474%
================================================
Files 1002 1002
Lines 137399 137598 +199
================================================
+ Hits 75777 75952 +175
- Misses 56074 56102 +28
+ Partials 5548 5544 -4
|
@@ -2,6 +2,7 @@ | |||
|
|||
set -eu | |||
|
|||
export DM_MASTER_EXTRA_ARG="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it overwrite the DM_MASTER_EXTRA_ARG set by GitHub secret?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just same with other test
Line 6 in 68c22f3
export DM_MASTER_EXTRA_ARG="" |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
1 similar comment
/retest |
@GMHDBJD: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #4287
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note