Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: fix upstream switch job test #11745

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Nov 14, 2024

What problem does this PR solve?

Issue Number: close #4287

What is changed and how it works?

  • add dependency
  • fix env variable
  • add feishu notification

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. area/dm Issues or PRs related to DM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1984%. Comparing base (b2a4f9a) to head (a86930c).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc 59.5875% <ø> (+0.0119%) ⬆️
dm 50.1269% <ø> (+0.0903%) ⬆️
engine 53.2618% <ø> (+0.0225%) ⬆️
Flag Coverage Δ
unit 55.1984% <ø> (+0.0474%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11745        +/-   ##
================================================
+ Coverage   55.1510%   55.1984%   +0.0474%     
================================================
  Files          1002       1002                
  Lines        137399     137598       +199     
================================================
+ Hits          75777      75952       +175     
- Misses        56074      56102        +28     
+ Partials       5548       5544         -4     
---- 🚨 Try these New Features:

@@ -2,6 +2,7 @@

set -eu

export DM_MASTER_EXTRA_ARG=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it overwrite the DM_MASTER_EXTRA_ARG set by GitHub secret?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just same with other test

export DM_MASTER_EXTRA_ARG=""

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-15 01:17:35.90729599 +0000 UTC m=+578218.098165010: ☑️ agreed by lance6716.
  • 2024-11-21 03:02:38.92114355 +0000 UTC m=+87146.540798066: ☑️ agreed by D3Hunter.

@lance6716
Copy link
Contributor

/retest

5 similar comments
@lance6716
Copy link
Contributor

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 21, 2024

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 22, 2024

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 22, 2024

/retest

@lance6716
Copy link
Contributor

/retest

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 23, 2024

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 24, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Nov 24, 2024

@GMHDBJD: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-kafka-test a86930c link true /test cdc-integration-kafka-test
pull-cdc-integration-pulsar-test a86930c link unknown /test cdc-integration-pulsar-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refine code
3 participants