Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy: Reduce proxy's size by compressing some debug sections (#8915) #8919

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Proxy: Reduce proxy's size by compressing some debug sections (#8915) #8919

merged 3 commits into from
Apr 9, 2024

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 9, 2024 •
edited by CalvinNeo
Loading

This is an automated cherry-pick of #8915

What problem does this PR solve?

Issue Number: close #8918

Problem Summary:
The debug info enlarge the size of tiflash-proxy a lot
pingcap/tidb-engine-ext#368

What is changed and how it works?

Compress the debug info of tiflash-proxy

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo and others added 3 commits April 9, 2024 08:44
@CalvinNeo @ti-chi-bot
z
b4a36f4 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo @JaySon-Huang @ti-chi-bot
Update contrib/tiflash-proxy-cmake/CMakeLists.txt
99d9dd4 
Co-authored-by: JaySon <[email protected]>
@CalvinNeo @ti-chi-bot
z
7960ec1 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 9, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
Merged
12 tasks
@CalvinNeo
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 9, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 9, 2024
JaySon-Huang
JaySon-Huang approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 09:07:03.026307741 +0000 UTC m=+953284.553848287: ☑️ agreed by CalvinNeo.
  • 2024-04-09 09:53:19.648016418 +0000 UTC m=+956061.175556961: ☑️ agreed by JaySon-Huang.

CalvinNeo
CalvinNeo approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CalvinNeo
Copy link
Member

/run-all-tests

@CalvinNeo
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 40bff06 into pingcap:release-8.1 Apr 9, 2024
5 checks passed
@Lloyd-Pottiger Lloyd-Pottiger mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@CalvinNeo CalvinNeo

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @CalvinNeo @JaySon-Huang