Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy: Reduce proxy's size by compressing some debug sections #8915

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Apr 9, 2024

What problem does this PR solve?

Issue Number: close #7256

Problem Summary:
The debug info enlarge the size of tiflash-proxy a lot
pingcap/tidb-engine-ext#368

What is changed and how it works?

Compress the debug info of tiflash-proxy

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

z
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 9, 2024
@CalvinNeo
Copy link
Member Author

image

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

contrib/tiflash-proxy-cmake/CMakeLists.txt Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 05:54:41.855855865 +0000 UTC m=+941743.383396413: ☑️ agreed by JaySon-Huang.
  • 2024-04-09 06:00:05.47186367 +0000 UTC m=+942066.999404214: ☑️ agreed by Lloyd-Pottiger.

@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

error while removing network: network tidb-ci_default id 4001227b88ecf7a46711e2c3a0808afb3e36032d1bf837b292177ea06ccbf588 has active endpoints

@CalvinNeo
Copy link
Member Author

/run-integration-test

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Apr 9, 2024

https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-integration-tests/detail/tiflash-ghpr-integration-tests/16305/pipeline/103/

[2024-04-09T07:08:15.819Z] fullstack-test2/ddl/alter_pk.test: Running
[2024-04-09T07:08:24.856Z]   File: fullstack-test2/ddl/alter_pk.test
[2024-04-09T07:08:24.856Z]   Error line: 35
[2024-04-09T07:08:24.856Z]   Error: DBGInvoke query_mapped('desc \$d.\$t', test, t)
[2024-04-09T07:08:24.856Z]   Result:
[2024-04-09T07:08:24.856Z]     ┌─name────────┬─type────────────┬─default_type─┬─default_expression─┐
[2024-04-09T07:08:24.856Z]     │ a           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ b           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ c           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ d           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ e           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ f           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ _tidb_rowid │ Int64           │              │                    │
[2024-04-09T07:08:24.856Z]     └─────────────┴─────────────────┴──────────────┴────────────────────┘
[2024-04-09T07:08:24.856Z]   Expected:
[2024-04-09T07:08:24.856Z]     ┌─name────────┬─type────────────┬─default_type─┬─default_expression─┐
[2024-04-09T07:08:24.856Z]     │ a           │ Int32           │              │                    │
[2024-04-09T07:08:24.856Z]     │ b           │ Int32           │              │                    │
[2024-04-09T07:08:24.856Z]     │ c           │ Int32           │              │                    │
[2024-04-09T07:08:24.856Z]     │ d           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ e           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ f           │ Nullable(Int32) │              │                    │
[2024-04-09T07:08:24.856Z]     │ _tidb_rowid │ Int64           │              │                    │
[2024-04-09T07:08:24.856Z]     └─────────────┴─────────────────┴──────────────┴────────────────────┘

@JaySon-Huang
Copy link
Contributor

/run-integration-test

z
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2024
@CalvinNeo
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 6bd9e6b into pingcap:master Apr 9, 2024
6 checks passed
@CalvinNeo
Copy link
Member Author

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@CalvinNeo: new pull request created to branch release-8.1: #8919.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CalvinNeo
Copy link
Member Author

/cherry-pick 8.1

@ti-chi-bot
Copy link
Member

@CalvinNeo: cannot checkout 8.1: error checking out 8.1: exit status 1. output: error: pathspec '8.1' did not match any file(s) known to git

In response to this:

/cherry-pick 8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor KVStore
4 participants