add two missing doctest end markers #4321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
approved these changes
Nov 15, 2024
lgoettgens
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
I missed one today as well (x-ref d95ac6f#diff-e7d341431dafa7950e2a01a4f03f5e87dc3d543c19a28c9fcb4a0c087f30a21fR53), so I would love to have some automatic testing for this (and maybe do another one for !!! warn instead of !!! warning)
|
A CI test for this would indeed be nice. That said, I am kinda surprised |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4321 +/- ##
=======================================
Coverage 84.49% 84.50%
=======================================
Files 645 645
Lines 85589 85589
=======================================
+ Hits 72321 72323 +2
+ Misses 13268 13266 -2
|
Closed
benlorenz
added a commit
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit 56c8f1f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminded by #4202 (comment) I ran my script from #2083 (comment) again and found two unterminated doctests.
Maybe I should add this to CI at some point.