Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backports release 1.2.1 #4326

Merged
merged 15 commits into from
Nov 21, 2024
Merged

backports release 1.2.1 #4326

merged 15 commits into from
Nov 21, 2024

Conversation

benlorenz
Copy link
Member

@benlorenz benlorenz commented Nov 18, 2024 •
edited by lgoettgens
Loading

ThomasBreuer and others added 7 commits November 18, 2024 12:22
@ThomasBreuer @benlorenz
fix _as_subgroups (#4277)
c73b41c 
and extend tests accordingly,
and fix `==` for group homomorphisms

(cherry picked from commit 8bea0b6)
@JohnAAbbott @benlorenz
Resolves BoundError in weights(hook_lengths(...)) (#4270)
8b9da34 
* Added arg check to weights

* weight seq of non-semi-standard YT gives error

* Inputs for weight seq tests are now semi-standard

(cherry picked from commit c40f14e)
@Sequenzer @benlorenz
fixed the leading zero bug in matroid_hex (#4299)
62cb44c 
(cherry picked from commit 2d7a2b0)
@paemurru @benlorenz
Update license (#4257)
9a881b8 
Co-authored-by: Max Horn <[email protected]>
(cherry picked from commit 953ad23)
@simonbrandhorst @benlorenz
Fixes small_generating_set, mininimal_primes over a number field (#4279)
6b1ba5f 
---------

Co-authored-by: HechtiDerLachs <[email protected]>
Co-authored-by: ederc <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Max Horn <[email protected]>
(cherry picked from commit e91af41)
@Sequenzer @benlorenz
changes to the check argument in matroid_from_matrix_columns (#4287)
a47f69e 
(cherry picked from commit b3ab222)
@fingolfin @benlorenz
Test and fix norm_equation for RelNumFieldOrder (#4282)
9956d02 
Co-authored-by: Tommy Hofmann <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
(cherry picked from commit a0d60ee)
@benlorenz benlorenz marked this pull request as draft November 18, 2024 11:30
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (cfb03fd) to head (b5cb648).
Report is 16 commits behind head on release-1.2.

Files with missing lines Patch % Lines
...gebraicGeometry/Schemes/Divisors/CartierDivisor.jl 0.00% 4 Missing ⚠️
...ebraicGeometry/Schemes/Divisors/AlgebraicCycles.jl 0.00% 2 Missing ⚠️
src/AlgebraicGeometry/Schemes/Gluing/Methods.jl 0.00% 2 Missing ⚠️
...metry/Schemes/ProjectiveSchemes/Objects/Methods.jl 0.00% 2 Missing ⚠️
src/NumberTheory/NmbThy.jl 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.2    #4326      +/-   ##
===============================================
+ Coverage        84.60%   84.63%   +0.03%     
===============================================
  Files              640      641       +1     
  Lines            85116    85144      +28     
===============================================
+ Hits             72010    72062      +52     
+ Misses           13106    13082      -24
Files with missing lines Coverage Δ
...imental/BasisLieHighestWeight/src/UserFunctions.jl 92.42% <ø> (ø)
experimental/SetPartitions/src/SetPartition.jl 100.00% <ø> (ø)
...cGeometry/Schemes/AffineSchemes/Objects/Methods.jl 92.34% <100.00%> (+0.06%) ⬆️
...gebraicGeometry/Schemes/Sheaves/CoherentSheaves.jl 80.80% <ø> (ø)
...Combinatorics/EnumerativeCombinatorics/tableaux.jl 96.43% <100.00%> (+<0.01%) ⬆️
src/Combinatorics/Matroids/ChowRings.jl 99.20% <ø> (ø)
src/Combinatorics/Matroids/matroids.jl 98.80% <100.00%> (ø)
src/Combinatorics/Matroids/properties.jl 98.33% <100.00%> (-0.02%) ⬇️
src/Groups/homomorphisms.jl 91.17% <100.00%> (ø)
src/Groups/sub.jl 95.65% <100.00%> (-0.14%) ⬇️
... and 11 more
---- 🚨 Try these New Features:

@benlorenz
add missing doctest markers (#4321)
bac9829 
(cherry picked from commit 56c8f1f)
@benlorenz
CI: check for jldoctest end markers and unknown admonitions (#4325)
1ca4ab9 
* CI: check for jldoctest end markers and unknown admonitions

* docs: fix two admonitions

* add explanation

* use !== nothing

(cherry picked from commit e8f8ecc)
@benlorenz benlorenz added the don't squash! do not squash the commits when merging label Nov 18, 2024
@benlorenz benlorenz marked this pull request as ready for review November 20, 2024 11:02
HechtiDerLachs and others added 6 commits November 20, 2024 14:20
@HechtiDerLachs @benlorenz
Add some dummy hash functions for the geometry (#4305)
5a9daa8 
(cherry picked from commit f96891f)
@fingolfin @benlorenz
bib: add a bunch of DOIs, minor corrections (#4317)
0aaadb8 
DOIs added via script from <https://tex.stackexchange.com/a/300474>.
The DOIs were then checked with <https://www.doi2bib.org> and in a
few cases further adjustments were made to the bib data.

(cherry picked from commit fb767f2)
@lkastner @benlorenz
issue/2142: Add subtype info to docs
5c874c9 
(cherry picked from commit 46d028f)
@aaruni96 @benlorenz
Patch search index (#4292)
a10b49a 
* Patch search index

This removes anything in search index that is not also present in doc.main.
That is, the search function will not return "hidden" pages, which are not
available via normal navigation.

* Move code to the right place, so its trigerred not just on interactive use

* Add JSON to docs Project.toml

* docs/search: improve doc.main parsing, use .html or / depending on local_build

---------

Co-authored-by: Benjamin Lorenz <[email protected]>
(cherry picked from commit d15b0c9)
@benlorenz
Version 1.2.1
b8fe19b
@antonydellavecchia @benlorenz
fixes regression and adds test for file format paper (#4335)
b5cb648 
(cherry picked from commit 5a737af)
versions adjusted for release branch
@benlorenz benlorenz merged commit 357fd97 into release-1.2 Nov 21, 2024
31 checks passed
@benlorenz benlorenz deleted the backports-release-1.2 branch November 21, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonydellavecchia antonydellavecchia antonydellavecchia approved these changes

Assignees
No one assigned
Labels
don't squash! do not squash the commits when merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.