feat: global screen wrapper #1321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
jcdrouin21
reviewed
Nov 21, 2024
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
|
jcdrouin21
reviewed
Nov 27, 2024
Comment on lines
+25
to
+47
| //Customizing Terms screen custom header | ||
| /* | ||
| this.container.registerInstance(TOKENS.OBJECT_ONBOARDING_CONFIG, { | ||
| ...DefaultScreenOptionsDictionary, | ||
| [Screens.Terms]: { | ||
| ...DefaultScreenOptionsDictionary[Screens.Terms], | ||
| headerShown: false, | ||
| }, | ||
| }) | ||
| this.container.registerInstance(TOKENS.OBJECT_LAYOUT_CONFIG, { | ||
| ...DefaultScreenLayoutOptions, | ||
| [Screens.Terms]: { | ||
| ...DefaultScreenLayoutOptions[Screens.Terms], | ||
| customEdges: ['bottom'], | ||
| safeArea: true, | ||
| Header: () => ( | ||
| <View style={{ backgroundColor: 'red', height: 129, justifyContent: 'center', alignItems: 'center' }}> | ||
| <Text style={{ color: 'white' }}>Custom Header</Text> | ||
| </View> | ||
| ), | ||
| }, | ||
| }) | ||
| */ |
jcdrouin21
reviewed
Nov 27, 2024
Comment on lines
+29
to
+34
| const { safeArea, customEdges, style, Header } = screenProps || { | ||
| safeArea: false, | ||
| customEdges: ['top', 'left', 'right', 'bottom'], | ||
| style: {}, | ||
| header: undefined, | ||
| } |
There was a problem hiding this comment.
It shouldn't be? :
const { safeArea, customEdges, style, Header } = screenProps || {
safeArea: false,
customEdges: ['top', 'left', 'right', 'bottom'],
style: {},
+ Header: undefined,
}
jcdrouin21
reviewed
Nov 27, 2024
| [Screens.Terms]: { | ||
| customEdges: ['top', 'left', 'right'], | ||
| }, | ||
| //TODO: Add more screens here |
There was a problem hiding this comment.
It should be clear that adding new screens here requires submitting a new PR to include the wrapper at the screen level as well.
However, I wonder if it might be more efficient to handle everything within this PR instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is a first step into having a global screen wrapper to allow more customization over pages layout
Included
Replace this text with a high-level summary of the changes included in this PR.
Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.