-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inject header right #1317
base: main
Are you sure you want to change the base?
feat: inject header right #1317
Conversation
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: Claude Arseneault <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a better approach! My only two gripes are:
- These are actually screen options, not stack options. If we call them stack options then we will have two separate and very different
defaultStackOptions
variables in our codebase. - You've moved some of the screen options to the
defaultStackOptions
but not all of them. It might be good to either keep them all in place, or move them all to the newdefaultStackOptions
. I would lean towards leaving them all in place.
Signed-off-by: ClaudeArs <[email protected]>
Quality Gate passedIssues Measures |
Does have some overlap with #1321 could work out a complete solution |
Ah right @ClaudeArs sorry I forgot a version of this already exists using dictionaries. See |
Ok @MosCD3 , the goal of this PR is to give the possibility to inject a button in the right part of the header. According to you, what would be the best way to proceed? |
Summary of Changes
This PR makes all header buttons injectable
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.