-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sass and address deprecation warnings #131
Update Sass and address deprecation warnings #131
Conversation
Bumps the npm-minor-upgrades group with 2 updates: [postcss](https://github.com/postcss/postcss) and [sass-embedded](https://github.com/sass/embedded-host-node). Updates `postcss` from 8.4.45 to 8.4.47 - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.45...8.4.47) Updates `sass-embedded` from 1.78.0 to 1.79.4 - [Changelog](https://github.com/sass/embedded-host-node/blob/main/CHANGELOG.md) - [Commits](sass/embedded-host-node@1.78.0...1.79.4) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor-upgrades - dependency-name: sass-embedded dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor-upgrades ... Signed-off-by: dependabot[bot] <[email protected]>
@mirisuzanne I'm not sure if this is even on the right track... And there are some uses of deprecated fns in documentation still (e.g. |
@jgerigmeyer yeah, I think we might want changes to the documentation. But maybe we can do this in two steps? Make sure things work upgrades, and open a new issue for updating the docs? |
@mirisuzanne There are some Herman build errors here: ➜ yarn docs
» [WARNING] Error compiling @example scss:
Error: $description: Expected "background" to be an unquoted string.
╷
9 │ background: color('background');
│ ^^^^^^^^^^^^^^^^^^^
╵
- 9:15 root stylesheet
@use 'tools';
@use 'sass:meta';
$colors: (
'background': #eee,
'text': #222,
);
html {
background: color('background');
color: color('text');
}
» [WARNING] Error compiling @example scss:
Error: $description: Expected "background-dark" to be an unquoted string.
╷
9 │ .component { background: color('background-dark'); }
│ ^^^^^^^^^^^^^^^^^^^^^^^^
╵
- 9:26 root stylesheet
@use 'tools';
@use 'sass:meta';
$colors: (
'background-dark': #222,
'accent': hsl(330, 85%, 62%),
);
@include tools.with-colors(('background-dark': #2c05bc));
.component { background: color('background-dark'); } |
Added #132 |
@mirisuzanne I attempted to address the Sass deprecation warnings. Could you take a look, and adjust documentation and/or changelog accordingly? These are showing up in all our projects now, so I'd love to get this resolved. |
This comment was marked as outdated.
This comment was marked as outdated.
@jgerigmeyer first glance looked good. I can try to take a closer look on the flight? Or @stacyk might be able to check it better? |
Bumps the npm-minor-upgrades group with 2 updates: postcss and sass-embedded.
Updates
postcss
from 8.4.45 to 8.4.47Release notes
Sourced from postcss's releases.
Changelog
Sourced from postcss's changelog.
Commits
5e6fd13
Release 8.4.47 version714bc10
Typo439d20e
Release 8.4.46 versionb93582f
Update dependenciesc51e467
Fix error on inserting node without raws in some cases829ae47
Update dependencies5aaaec2
Update remaining workflow jobs to use latest version of actions (#1968)Updates
sass-embedded
from 1.78.0 to 1.79.4Changelog
Sourced from sass-embedded's changelog.
... (truncated)
Commits
1a63ffa
Update Dart Sass version and release8818ed1
Update Dart Sass version and release87eacff
Update Dart Sass version and releasedf6f478
Add documentation link to legacy JS API warning (#333)59dde59
Update Dart Sass version and releasec4824db
Emit deprecation warnings for legacy JS API (#331)f8e1a7b
Merge pull request #330 from sass/feature.color-4e146240
Remove -dev from embedded protocolddff73f
Merge pull request #329 from sass/merge-main9f10f60
Merge branch 'main' of github.com:sass/embedded-host-node into feature.color-4Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions