Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sass and address deprecation warnings #131

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 1, 2024

Bumps the npm-minor-upgrades group with 2 updates: postcss and sass-embedded.

Updates postcss from 8.4.45 to 8.4.47

Release notes

Sourced from postcss's releases.

8.4.47

  • Removed debug code.

8.4.46

  • Fixed Cannot read properties of undefined (reading 'before').
Changelog

Sourced from postcss's changelog.

8.4.47

  • Removed debug code.

8.4.46

  • Fixed Cannot read properties of undefined (reading 'before').
Commits

Updates sass-embedded from 1.78.0 to 1.79.4

Changelog

Sourced from sass-embedded's changelog.

1.79.4

JS API

  • Fix a bug where passing green or blue to color.change() for legacy colors would fail.

1.79.3

  • Update the $channel parameter in the suggested replacement for color.red(), color.green(), color.blue(), color.hue(), color.saturation(), color.lightness(), color.whiteness(), and color.blackness() to use a quoted string.

1.79.2

  • Add a $space parameter to the suggested replacement for color.red(), color.green(), color.blue(), color.hue(), color.saturation(), color.lightness(), color.whiteness(), and color.blackness().

  • Update deprecation warnings for the legacy JS API to include a link to relevant documentation.

1.79.1

  • No user-visible changes.

1.79.0

  • Breaking change: Passing a number with unit % to the $alpha parameter of color.change(), color.adjust(), change-color(), and adjust-color() is now interpreted as a percentage, instead of ignoring the unit. For example, color.change(red, $alpha: 50%) now returns rgb(255 0 0 / 0.5).

  • Potentially breaking compatibility fix: Sass no longer rounds RGB channels to the nearest integer. This means that, for example, rgb(0 0 1) != rgb(0 0 0.6). This matches the latest version of the CSS spec and browser behavior.

  • Potentially breaking compatibility fix: Passing large positive or negative values to color.adjust() can now cause a color's channels to go outside that color's gamut. In most cases this will currently be clipped by the browser and end up showing the same color as before, but once browsers implement gamut mapping it may produce a different result.

  • Add support for CSS Color Level 4 [color spaces]. Each color value now tracks its color space along with the values of each channel in that color space. There are two general principles to keep in mind when dealing with new color spaces:

... (truncated)

Commits
  • 1a63ffa Update Dart Sass version and release
  • 8818ed1 Update Dart Sass version and release
  • 87eacff Update Dart Sass version and release
  • df6f478 Add documentation link to legacy JS API warning (#333)
  • 59dde59 Update Dart Sass version and release
  • c4824db Emit deprecation warnings for legacy JS API (#331)
  • f8e1a7b Merge pull request #330 from sass/feature.color-4
  • e146240 Remove -dev from embedded protocol
  • ddff73f Merge pull request #329 from sass/merge-main
  • 9f10f60 Merge branch 'main' of github.com:sass/embedded-host-node into feature.color-4
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the npm-minor-upgrades group with 2 updates: [postcss](https://github.com/postcss/postcss) and [sass-embedded](https://github.com/sass/embedded-host-node).


Updates `postcss` from 8.4.45 to 8.4.47
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.45...8.4.47)

Updates `sass-embedded` from 1.78.0 to 1.79.4
- [Changelog](https://github.com/sass/embedded-host-node/blob/main/CHANGELOG.md)
- [Commits](sass/embedded-host-node@1.78.0...1.79.4)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-minor-upgrades
- dependency-name: sass-embedded
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-upgrades
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 1, 2024
@jgerigmeyer
Copy link
Member

@mirisuzanne I'm not sure if this is even on the right track... And there are some uses of deprecated fns in documentation still (e.g. darken and desaturate).

@mirisuzanne
Copy link
Member

@jgerigmeyer yeah, I think we might want changes to the documentation. But maybe we can do this in two steps? Make sure things work upgrades, and open a new issue for updating the docs?

@jgerigmeyer
Copy link
Member

@mirisuzanne There are some Herman build errors here:

➜ yarn docs
» [WARNING] Error compiling @example scss:
Error: $description: Expected "background" to be an unquoted string.
  ╷
9 │   background: color('background');
  │               ^^^^^^^^^^^^^^^^^^^
  ╵
  - 9:15  root stylesheet
@use 'tools';
@use 'sass:meta';
$colors: (
  'background': #eee,
  'text': #222,
);

html {
  background: color('background');
  color: color('text');
}
» [WARNING] Error compiling @example scss:
Error: $description: Expected "background-dark" to be an unquoted string.
  ╷
9 │ .component { background: color('background-dark'); }
  │                          ^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  - 9:26  root stylesheet
@use 'tools';
@use 'sass:meta';
$colors: (
  'background-dark': #222,
  'accent': hsl(330, 85%, 62%),
);

@include tools.with-colors(('background-dark': #2c05bc));
.component { background: color('background-dark'); }

@jgerigmeyer
Copy link
Member

I think we might want changes to the documentation. But maybe we can do this in two steps? Make sure things work upgrades, and open a new issue for updating the docs?

Added #132

@jgerigmeyer
Copy link
Member

@mirisuzanne I attempted to address the Sass deprecation warnings. Could you take a look, and adjust documentation and/or changelog accordingly? These are showing up in all our projects now, so I'd love to get this resolved.

@jgerigmeyer jgerigmeyer changed the title Bump the npm-minor-upgrades group with 2 updates Update Sass and address deprecation warnings Oct 31, 2024

This comment was marked as outdated.

@dependabot dependabot bot closed this Nov 1, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/npm-minor-upgrades-c287d5e417 branch November 1, 2024 08:53
@jgerigmeyer jgerigmeyer restored the dependabot/npm_and_yarn/npm-minor-upgrades-c287d5e417 branch November 1, 2024 17:05
@jgerigmeyer jgerigmeyer reopened this Nov 1, 2024
@mirisuzanne
Copy link
Member

@jgerigmeyer first glance looked good. I can try to take a closer look on the flight? Or @stacyk might be able to check it better?

@jgerigmeyer jgerigmeyer linked an issue Nov 7, 2024 that may be closed by this pull request
@jgerigmeyer jgerigmeyer merged commit 50db1dd into main Nov 7, 2024
6 checks passed
@jgerigmeyer jgerigmeyer deleted the dependabot/npm_and_yarn/npm-minor-upgrades-c287d5e417 branch November 7, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
3 participants