Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass deprecation warnings for use of RGB color functions #133

Closed
johncrim opened this issue Oct 9, 2024 · 1 comment · Fixed by #131
Closed

Sass deprecation warnings for use of RGB color functions #133

johncrim opened this issue Oct 9, 2024 · 1 comment · Fixed by #131
Assignees

Comments

@johncrim
Copy link
Contributor

johncrim commented Oct 9, 2024

During our build with accoutrement 4.0.4 and sass 1.79.4 I'm seeing a number of deprecation warnings from code in the Accoutrement lib, like these:

Deprecation Warning: color.red() is deprecated. Suggestion:                                                                                                                                                                                                            

color.channel($color, "red", $space: rgb)

More info: https://sass-lang.com/d/color-functions

    ╷
225 │     'r': math.div(color.red($color), 255),
    │                   ^^^^^^^^^^^^^^^^^
    ╵
    node_modules\accoutrement\sass\color\_contrast.scss 225:19  luminance()
    node_modules\accoutrement\sass\color\_contrast.scss 335:15  best-contrast()
    node_modules\accoutrement\sass\color\_contrast.scss 84:11   contrast()
    theme\_color.scss 89:15                                     foreground()
    theme\_color.scss 167:12                                    Background()
    libs\style\test\theme-color.spec.scss 48:9                  @content


Deprecation Warning: color.green() is deprecated. Suggestion:

color.channel($color, "green", $space: rgb)

More info: https://sass-lang.com/d/color-functions

    ╷
226 │     'g': math.div(color.green($color), 255),
    │                   ^^^^^^^^^^^^^^^^^^^
    ╵
    node_modules\accoutrement\sass\color\_contrast.scss 226:19  luminance()
    node_modules\accoutrement\sass\color\_contrast.scss 335:15  best-contrast()
    node_modules\accoutrement\sass\color\_contrast.scss 84:11   contrast()
    theme\_color.scss 89:15                                     foreground()
    theme\_color.scss 167:12                                    Background()
    libs\style\test\theme-color.spec.scss 48:9                  @content

I've already fixed similar warnings in our code, it's a pretty straightforward fix. I may be able to make the fix in this project, I just don't have time for it today.

@jgerigmeyer
Copy link
Member

@johncrim Thanks for reporting! This should be fixed by #131, once we get that wrapped up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants