Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses #2119 NTR perivascular cell #2120

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Addresses #2119 NTR perivascular cell #2120

merged 3 commits into from
Aug 23, 2023

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #2119 NTR perivascular cell

@aleixpuigb
Addresses #2119 NTR perivascular cell
349a05d 
Fixes #2119 NTR perivascular cell
@aleixpuigb aleixpuigb self-assigned this Aug 22, 2023
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-08-22/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-08-22/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4033054 http://purl.obolibrary.org/obo/CL_4033054

Added

lymphangioblast http://purl.obolibrary.org/obo/CL_0005020

Added

mural cell http://purl.obolibrary.org/obo/CL_0008034

Added

perivascular macrophage http://purl.obolibrary.org/obo/CL_0000881

Added

vascular associated smooth muscle cell http://purl.obolibrary.org/obo/CL_0000359

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4033054 http://purl.obolibrary.org/obo/CL_4033054

Added

mural cell http://purl.obolibrary.org/obo/CL_0008034

Added

perivascular macrophage http://purl.obolibrary.org/obo/CL_0000881

Added

vascular associated smooth muscle cell http://purl.obolibrary.org/obo/CL_0000359

Added

@aleixpuigb aleixpuigb requested a review from a user August 22, 2023 14:50
ghost
ghost suggested changes Aug 23, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

@aleixpuigb aleixpuigb requested a review from a user August 23, 2023 09:35
ghost
ghost reviewed Aug 23, 2023
View reviewed changes
src/ontology/cl-edit.owl
@@ -31843,6 +31847,14 @@ AnnotationAssertion(rdfs:label obo:CL_4033053 "small bistratified retinal gangli
SubClassOf(obo:CL_4033053 obo:CL_0003001)
SubClassOf(obo:CL_4033053 ObjectSomeValuesFrom(obo:RO_0002100 obo:UBERON_0001792))

# Class: obo:CL_4033054 (perivascular cell)

AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:24928499") Annotation(oboInOwl:hasDbXref "PMID:27889329") obo:IAO_0000115 obo:CL_4033054 "A cell that is adjacent to a vessel. A perivascular cell plays a crucial role in maintaining vascular function and tissue homeostasis. This cell regulates vessel integrity and flow dynamics.")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider editing last sentence to: This cell type regulates vessel integrity and flow dynamics.

Will approve PR and leave this edit to your discretion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion, I will add it now.

@aleixpuigb
Improve definition
acdb1b3 
This cell regulates -> This cell type regulates
@aleixpuigb aleixpuigb merged commit c87fc2a into master Aug 23, 2023
1 check passed
@aleixpuigb aleixpuigb deleted the 2119_NTR_perivascular_cell branch August 23, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@aleixpuigb aleixpuigb

Labels
cellxgene HuBMAP Needed/useful for HuBMAP new term request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NTR] perivascular cell
1 participant
@aleixpuigb