Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "allow installing multiple modules from a single package (#33)" #50

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Revert "allow installing multiple modules from a single package (#33)" #50

merged 1 commit into from
Dec 13, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Dec 11, 2023

@amtoine amtoine mentioned this pull request Dec 11, 2023
Open
4 tasks
@kubouch
Copy link
Contributor

kubouch commented Dec 13, 2023

After this it seems like default script will be required again (see description in #33 ), we might want to patch this at some point.

@kubouch kubouch merged commit 6a9618f into nushell:main Dec 13, 2023
3 checks passed
@amtoine amtoine deleted the revert-33 branch December 13, 2023 21:01
@amtoine amtoine mentioned this pull request Dec 15, 2023
Merged
1 task
@amtoine
Copy link
Member Author

amtoine commented Dec 15, 2023 •
edited
Loading

some packages to fix because this did land

amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Dec 15, 2023
@amtoine
bump Nushell and Nupm (#140)
529ff39 
this PR
- bumps Nushell to `0.88.1`
- bumps Nupm to
nushell/nupm@6a9618f
and nushell/nupm#50

## full changelog
- move the `src/nu-git-manager/` module to
`pkgs/nu-git-manager/nu-git-manager/`
- move the `src/nu-git-manager-sugar/` module to
`pkgs/nu-git-manager/nu-git-manager-sugar/`
- split `package.nuon` into `pkgs/nu-git-manager/package.nuon` and
`pkgs/nu-git-manager-sugar/package.nuon
- fix all the imports, especially in the tests
- fix the `install-package` test of `nu-git-manager`
- clone the `install-package` test from `nu-git-manager` to
`nu-git-manager-sugar`
- fix the listing of modules in the toolkit

## TODO
- [x] fix the CI => #135
This was referenced Dec 15, 2023
Merged
Merged
@amtoine
Copy link
Member Author

amtoine commented Dec 16, 2023

all the packages have been fixed or have a PR in the queue that will fix them 👍

kubouch pushed a commit that referenced this pull request Dec 17, 2023
@amtoine
update the index (#54)
bf17351 
related to
- #50
- amtoine/nu-git-manager#140
- nushell/nu_scripts#700

## Description
#50 forces some packages with multiple modules to be split into multiple
packages.
this is the case of `amtoine/nu-git-manager` and `nushell/nu_scripts`
and this PR reflects this new set of packages.

> **Note**
> the script given as an example in
#49 might not work for now with the
ongoing transition from `package.nuon` to `nupm.nuon` in
#49
amtoine added a commit to nushell/nu_scripts that referenced this pull request Feb 18, 2024
@amtoine
split the package into nu-themes and nu-hooks (#700)
4180ce8 
related to 
- nushell/nupm#50

## description
`nu-scripts` was not really a package but rather a set of two module
packages.
this feature has been removed from Nupm in
nushell/nupm#50 and this PR fixes the
`nu-scripts` packages.

> **Note**
> the files in `nu-hooks/` have been moved to `nu-hooks/nu-hooks/` to
fit into the current model of Nupm

this PR does not change anything from the user point of view, apart from
the install that goes from
```nushell
nupm install --path --force .
```
to
```nushell
for pkg in (ls **/package.nuon | get name | path dirname) {
    nupm install --force --path $pkg
}
```
maxim-uvarov pushed a commit to maxim-uvarov/nu_scripts_reduced_size that referenced this pull request Oct 12, 2024
@amtoine
split the package into nu-themes and nu-hooks (#700)
cab4ead 
related to 
- nushell/nupm#50

## description
`nu-scripts` was not really a package but rather a set of two module
packages.
this feature has been removed from Nupm in
nushell/nupm#50 and this PR fixes the
`nu-scripts` packages.

> **Note**
> the files in `nu-hooks/` have been moved to `nu-hooks/nu-hooks/` to
fit into the current model of Nupm

this PR does not change anything from the user point of view, apart from
the install that goes from
```nushell
nupm install --path --force .
```
to
```nushell
for pkg in (ls **/package.nuon | get name | path dirname) {
    nupm install --force --path $pkg
}
```
maxim-uvarov pushed a commit to maxim-uvarov/nu_scripts_reduced_size that referenced this pull request Oct 13, 2024
@amtoine
split the package into nu-themes and nu-hooks (#700)
e28a9bc 
related to 
- nushell/nupm#50

## description
`nu-scripts` was not really a package but rather a set of two module
packages.
this feature has been removed from Nupm in
nushell/nupm#50 and this PR fixes the
`nu-scripts` packages.

> **Note**
> the files in `nu-hooks/` have been moved to `nu-hooks/nu-hooks/` to
fit into the current model of Nupm

this PR does not change anything from the user point of view, apart from
the install that goes from
```nushell
nupm install --path --force .
```
to
```nushell
for pkg in (ls **/package.nuon | get name | path dirname) {
    nupm install --force --path $pkg
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amtoine @kubouch