Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split the package into nu-themes and nu-hooks #700

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Dec 15, 2023

related to

description

nu-scripts was not really a package but rather a set of two module packages.
this feature has been removed from Nupm in nushell/nupm#50 and this PR fixes the nu-scripts packages.

Note
the files in nu-hooks/ have been moved to nu-hooks/nu-hooks/ to fit into the current model of Nupm

this PR does not change anything from the user point of view, apart from the install that goes from

nupm install --path --force .

to

for pkg in (ls **/package.nuon | get name | path dirname) {
    nupm install --force --path $pkg
}

kubouch pushed a commit to nushell/nupm that referenced this pull request Dec 17, 2023
related to
- #50
- amtoine/nu-git-manager#140
- nushell/nu_scripts#700

## Description
#50 forces some packages with multiple modules to be split into multiple
packages.
this is the case of `amtoine/nu-git-manager` and `nushell/nu_scripts`
and this PR reflects this new set of packages.

> **Note**
> the script given as an example in
#49 might not work for now with the
ongoing transition from `package.nuon` to `nupm.nuon` in
#49
@amtoine
Copy link
Member Author

amtoine commented Feb 18, 2024

i think i'll land this, as it's conflicting with Nupm and its index.nuon 🤔

@amtoine amtoine merged commit 4180ce8 into nushell:main Feb 18, 2024
@amtoine amtoine deleted the fix-packages branch February 18, 2024 15:21
amtoine added a commit that referenced this pull request Feb 18, 2024
related to
- nushell/nupm#51

depends on
- #700

> **Important**
> this PR will be rebased once #700 lands and only
a5a6b6f
is relevant here

## description
this is a simple rename of `package.nuon` files to `nupm.nuon` as per
nushell/nupm#51.
maxim-uvarov pushed a commit to maxim-uvarov/nu_scripts_reduced_size that referenced this pull request Oct 12, 2024
related to
- nushell/nupm#51

depends on
- nushell/nu_scripts#700

> **Important**
> this PR will be rebased once #700 lands and only
nushell/nu_scripts@a5a6b6f
is relevant here

## description
this is a simple rename of `package.nuon` files to `nupm.nuon` as per
nushell/nupm#51.
maxim-uvarov pushed a commit to maxim-uvarov/nu_scripts_reduced_size that referenced this pull request Oct 13, 2024
related to
- nushell/nupm#51

depends on
- nushell/nu_scripts#700

> **Important**
> this PR will be rebased once #700 lands and only
nushell/nu_scripts@a5a6b6f
is relevant here

## description
this is a simple rename of `package.nuon` files to `nupm.nuon` as per
nushell/nupm#51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant