Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data build from develop #713

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

twhetzel
Copy link
Contributor

@twhetzel twhetzel commented Nov 27, 2024

Resolves #ISSUE(s).

Overview

This PR:
Is a full data build from develop (after Nico merged main into develop) for the Week 4, Step 2 task for the Mondo Ingest development and build cycle. This PR is intended to be merged into main and a Merge Commit should be used.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

  • Yes
  • No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

  • Yes
  • No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

  • Yes

joeflack4 and others added 5 commits November 26, 2024 20:48
* Remove GARD
Remove GARD as non-EMC source
- ODK setup: metadata/gard.yml & mondo-ingest-odk.yaml
- Specific files: docs, outputs, and intermediaries.
- Refs within files: mondo-ingest.Makefile, gitignore, mkdocs.yml, Makefile (after running update_repo)

* Re-ran update_repo after merging develop
@twhetzel twhetzel added the build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes label Nov 27, 2024
@twhetzel twhetzel self-assigned this Nov 27, 2024
Copy link
Contributor

@joeflack4 joeflack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synonym sync diffs are still bigger than I would expect because of a sorting issue caused by another issue which will be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants