Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Solr group queries to Solr service #914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ptgolden
Copy link
Member

@ptgolden ptgolden commented Nov 26, 2024

This adds a new method for the Solr service, .group_query(), which allows running Solr queries which group returned documents.

https://solr.apache.org/guide/6_6/result-grouping.html

This only implements the group.query option, not group.field or group.func.

Related issues

Checks

  • All tests have passed (or issues created for failing tests)

This adds a new method for the Solr service, `.group_query()`, which
allows running Solr queries which group returned documents.

<https://solr.apache.org/guide/6_6/result-grouping.html>

This only implements the `group.query` option, not `group.field` or
`group.func`.
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for monarch-app canceled.

Name Link
🔨 Latest commit b87a51b
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/6745f6a8dcf4c400084e56a5

@ptgolden
Copy link
Member Author

(Also related to #821 and possibly #841)

@ptgolden
Copy link
Member Author

It's possible that grouped_query might be a better name for the method-- what do you think @kevinschaper?

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.06%. Comparing base (af5ab7b) to head (b87a51b).

Files with missing lines Patch % Lines
backend/src/monarch_py/service/solr_service.py 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
- Coverage   71.14%   71.06%   -0.08%     
==========================================
  Files          91       91              
  Lines        3136     3166      +30     
==========================================
+ Hits         2231     2250      +19     
- Misses        905      916      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant