Feature/add idfa parameter to release #162
Conversation
Is missing the actual implementation
|
|
|
I'm currently testing this, managed to upload it. It still needs some work as you don't only want to add the part of the command if the value is true, also when it's not... |
|
I can't get this to work with any variation on quotes and escaped quotes etc. Maybe someone witha bit more fastlane knowledge can get this to work.... |
|
Hi @DaVaMa1, thanks for contribution! We will review these changes once we will start working on related issue |
| @@ -258,6 +259,7 @@ async function run() { | |||
| deliverCommand.argIf(teamName, ['-e', teamName]); | |||
| deliverCommand.argIf(shouldSubmitForReview, ['--submit_for_review', 'true']); | |||
| deliverCommand.argIf(shouldAutoRelease, ['--automatic_release', 'true']); | |||
| deliverCommand.argIf(usesIdfa, ['--submission_information', `'{'add_id_info_uses_idfa': ${usesIdfa}}'`]); | |||
There was a problem hiding this comment.
This change could be unobvious - fastlane command tools doesn't support repeated flags, so if fastlaneArguments is defined - '--submission_information' there could override this value
|
Looks like these changes break backward compatibility and could make task inputs less orthogonal - since fastlane doesn't support repeated flags at the moment. To resolve compatibility issue - we could increase major task version, but not sure if decreasing of inputs orthogonality is the right direction here. |
This is still untested as I din't have access to a working pipeline to which I'm allowed to upload tasks. I'm not sure if this is going to work, but I'm pretty sure that it should....