Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDFA is required to submit #160

Closed
mobileappd opened this issue Aug 12, 2020 · 6 comments · May be fixed by #162
Closed

IDFA is required to submit #160

mobileappd opened this issue Aug 12, 2020 · 6 comments · May be fixed by #162

Comments

@mobileappd
Copy link

Hi there,

I'm not sure if this is something already addressed and I just missed it, but since a few months idfa is required to submit an app to the app store. If it is not specified, you get an error like:

[!] Use of Advertising Identifier (IDFA) is required to submit
Add information to the :submission_information option...
Docs: http://docs.fastlane.tools/actions/deliver/#compliance-and-idfa-settings
Example: submission_information: { add_id_info_uses_idfa: false }
Example: submission_information: {
add_id_info_uses_idfa: true,
add_id_info_serves_ads: false,
add_id_info_tracks_install: true,
add_id_info_tracks_action: true,
add_id_info_limits_tracking: true
}
Example CLI:
--submission_information "{"add_id_info_uses_idfa": false}"

Seeing as this is a requirement to submit, is there a chance this can be added as a required field in the task?

We're currently not sure how to add it otherwise, we're going to test it through our pipeline during our next release in a few weeks by adding additional arguments to fastlane through the field provided by the extension, but since it required, a field in the tasks seems like a more logical place imo.

@mobileappd mobileappd changed the title IDFA is required to sugmit IDFA is required to submit Aug 12, 2020
@luizgrs
Copy link
Contributor

luizgrs commented Aug 14, 2020

fastLaneArguments seems to do not work here:

- task: AppStorePromote@1
            inputs:
              ...
              fastlaneArguments: '-b "{\"add_id_info_uses_idfa\": false}"'

fails with

[!] 'submission_information' value must be a Hash! Found String instead.

and using the long arg name also fails:

          - task: AppStorePromote@1
            inputs:
              ...
              fastlaneArguments: '--submission_information "{\"add_id_info_uses_idfa\": false}"'

invalid option: --submission_information "{"add_id_info_uses_idfa": false}"

It seems fastlaneArguments doesnt work quite well, I also had other issues when trying to use it to setup -z and had to fallback to environment variables. but environment variable isnt an option for submission_information..

According to fastlane docs using the argument that way should work. I tried in my computer and it worked. The issue might be in how that extra arguments are getting appended to the command

@DaVaMa1
Copy link

DaVaMa1 commented Aug 17, 2020

I've made a fork with something which I think should work, but I dont have an app store account and I'm not allowed to upload my own extensions with my company, so I can't test if it works.

I'm not allowed to push a branch to this repository, no idea how I'm supposed to make a proposal.

@anatolybolshakov
Copy link
Contributor

Hi @DaVaMa1 you could specify submission_information by defining fastlaneArguments values like '--submission_information "{\"add_id_info_uses_idfa\": false}"' - could you please try it?
It works currently for App store release task - we already merge the fix (PR) and going to release it soon, thanks @luizgrs for the contribution!

@anatolybolshakov
Copy link
Contributor

Hi @DaVaMa1 is this issue still actual for you?

@DaVaMa1
Copy link

DaVaMa1 commented Sep 18, 2020

Hi, my apologies for the late response.

I can try this again next monday, I'll let you now then if it works.

I'll trust that a new release fixes this, and you can consider this closed from my part.

@anatolybolshakov
Copy link
Contributor

@DaVaMa1 ok, thanks! I'm closing it at the moment, please feel free to reopen it if there's still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants